From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D0C4A45453 for ; Wed, 1 Mar 2023 14:34:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1793468AA32; Wed, 1 Mar 2023 16:34:53 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 860C3680AEB for ; Wed, 1 Mar 2023 16:34:46 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 4D58D2404EC; Wed, 1 Mar 2023 15:34:46 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id zeVkC_UPwS2r; Wed, 1 Mar 2023 15:34:45 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id BD9D1240178; Wed, 1 Mar 2023 15:34:45 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id AEDBE1601B2; Wed, 1 Mar 2023 15:34:45 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230301000126.49666-1-stefasab@gmail.com> References: <20230301000126.49666-1-stefasab@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches , Stefano Sabatini Date: Wed, 01 Mar 2023 15:34:45 +0100 Message-ID: <167768128568.10789.2704017138064423865@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: issue more specific error in case of invalid parameters X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Stefano Sabatini Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Stefano Sabatini (2023-03-01 01:01:26) > --- > libavfilter/buffersrc.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c > index ba17450b93..ea9556d691 100644 > --- a/libavfilter/buffersrc.c > +++ b/libavfilter/buffersrc.c > @@ -273,9 +273,16 @@ static av_cold int init_video(AVFilterContext *ctx) > { > BufferSourceContext *c = ctx->priv; > > - if (c->pix_fmt == AV_PIX_FMT_NONE || !c->w || !c->h || > - av_q2d(c->time_base) <= 0) { > - av_log(ctx, AV_LOG_ERROR, "Invalid parameters provided.\n"); > + if (c->pix_fmt == AV_PIX_FMT_NONE) { > + av_log(ctx, AV_LOG_ERROR, "Unspecified pixel format\n"); > + return AVERROR(EINVAL); > + } > + if (!c->w || !c->h) { > + av_log(ctx, AV_LOG_ERROR, "Invalid null size %dx%d\n", c->w, c->h); ^^^^ I don't know what a null size is, just drop the word. Otherwise looks good. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".