Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: issue more specific error in case of invalid parameters

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Stefano Sabatini <stefasab@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: issue more specific error in case of invalid parameters
Date: Wed, 01 Mar 2023 15:34:45 +0100
Message-ID: <167768128568.10789.2704017138064423865@lain.khirnov.net> (raw)
In-Reply-To: <20230301000126.49666-1-stefasab@gmail.com>

Quoting Stefano Sabatini (2023-03-01 01:01:26)
> ---
>  libavfilter/buffersrc.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c
> index ba17450b93..ea9556d691 100644
> --- a/libavfilter/buffersrc.c
> +++ b/libavfilter/buffersrc.c
> @@ -273,9 +273,16 @@ static av_cold int init_video(AVFilterContext *ctx)
>  {
>      BufferSourceContext *c = ctx->priv;
>  
> -    if (c->pix_fmt == AV_PIX_FMT_NONE || !c->w || !c->h ||
> -        av_q2d(c->time_base) <= 0) {
> -        av_log(ctx, AV_LOG_ERROR, "Invalid parameters provided.\n");
> +    if (c->pix_fmt == AV_PIX_FMT_NONE) {
> +        av_log(ctx, AV_LOG_ERROR, "Unspecified pixel format\n");
> +        return AVERROR(EINVAL);
> +    }
> +    if (!c->w || !c->h) {
> +        av_log(ctx, AV_LOG_ERROR, "Invalid null size %dx%d\n", c->w, c->h);
                                              ^^^^
I don't know what a null size is, just drop the word.

Otherwise looks good.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".