From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id ACD724544B for ; Wed, 1 Mar 2023 14:34:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BAFFB68A630; Wed, 1 Mar 2023 16:33:58 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7AED668A621 for ; Wed, 1 Mar 2023 16:33:52 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 33BF22404EC for ; Wed, 1 Mar 2023 15:33:52 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id WZTUPmnvoAl5 for ; Wed, 1 Mar 2023 15:33:51 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 813B2240178 for ; Wed, 1 Mar 2023 15:33:51 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 63F8F1601B2; Wed, 1 Mar 2023 15:33:51 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230301000529.GE25822@mariano> References: <20230301000126.49666-1-stefasab@gmail.com> <20230301000529.GE25822@mariano> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 01 Mar 2023 15:33:51 +0100 Message-ID: <167768123137.10789.4946510304332024194@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: issue more specific error in case of invalid parameters X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Stefano Sabatini (2023-03-01 01:05:29) > On date Wednesday 2023-03-01 01:01:26 +0100, Stefano Sabatini wrote: > > --- > > libavfilter/buffersrc.c | 13 ++++++++++--- > > 1 file changed, 10 insertions(+), 3 deletions(-) > > > > diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c > > index ba17450b93..ea9556d691 100644 > > --- a/libavfilter/buffersrc.c > > +++ b/libavfilter/buffersrc.c > > @@ -273,9 +273,16 @@ static av_cold int init_video(AVFilterContext *ctx) > > { > > BufferSourceContext *c = ctx->priv; > > > > - if (c->pix_fmt == AV_PIX_FMT_NONE || !c->w || !c->h || > > - av_q2d(c->time_base) <= 0) { > > - av_log(ctx, AV_LOG_ERROR, "Invalid parameters provided.\n"); > > + if (c->pix_fmt == AV_PIX_FMT_NONE) { > > + av_log(ctx, AV_LOG_ERROR, "Unspecified pixel format\n"); > > + return AVERROR(EINVAL); > > + } > > + if (!c->w || !c->h) { > > + av_log(ctx, AV_LOG_ERROR, "Invalid null size %dx%d\n", c->w, c->h); > > + return AVERROR(EINVAL); > > + } > > + if (av_q2d(c->time_base) <= 0) { > > + av_log(ctx, AV_LOG_ERROR, "Invalid time base %d/%d\n", c->time_base.num, c->time_base.den); > > return AVERROR(EINVAL); > > } > > BTW, I noticied this as part of debugging transcode.c (which looks > broken at the moment), since the timebase is read as 0/1 from the > decoder context, it would be a valid value when reading from the > AVStream (but this information is not copied by > avcodec_parameters_to_context). In decode_filter_video.c this is > indeed "fixed" by copying the timebase directly from the AVStream. > > Is this expected? Shouldn't the timebase be copied to the decoder > context? Historically, AVCodecContext.time_base for decoding was NOT (as one might expect) the timebase of input packets, set by the user. It was instead the inverse of the framerate stored in codec-level headers, which was called "codec timebase" by some documents. Since that was massively confusing for pretty much everyone, I added AVCodecContext.framerate for exporting the framerate from the decoder, and deprecated the use of AVCodecContext.time_base for decoding entirely. After the recent major bump, time_base should not be used at all in any way when decoding. The timebase of input packets should instead be stored in AVCodecContext.pkt_timebase. I suppose after some time has passed we might want to merge its functionality into time_base. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".