From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7935A4575B for ; Mon, 20 Feb 2023 17:21:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1C9E168C055; Mon, 20 Feb 2023 19:21:20 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 98A7768BC75 for ; Mon, 20 Feb 2023 19:21:13 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id DD5C42404EE for ; Mon, 20 Feb 2023 18:21:11 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 5MWW6XcQo4yD for ; Mon, 20 Feb 2023 18:21:11 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 3C4F42404EC for ; Mon, 20 Feb 2023 18:21:11 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 207D21601B2; Mon, 20 Feb 2023 18:21:11 +0100 (CET) From: Anton Khirnov To: Ffmpeg Devel In-Reply-To: References: Mail-Followup-To: Ffmpeg Devel Date: Mon, 20 Feb 2023 18:21:11 +0100 Message-ID: <167691367110.10789.13673219029256059802@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 00/72] Implement support for Vulkan multiplane images and video decoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Lynne (2023-02-17 04:43:50) > From 52ab3cd8d165a838be92189c87c54915efc1c7e5 Mon Sep 17 00:00:00 2001 > From: Lynne > Date: Wed, 11 Jan 2023 05:20:32 +0100 > Subject: [PATCH 10/72] h264dec: track picture_structure in H264Picture > > --- > libavcodec/h264_picture.c | 1 + > libavcodec/h264_slice.c | 1 + > libavcodec/h264dec.h | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/libavcodec/h264_picture.c b/libavcodec/h264_picture.c > index 2661ff4698..0348166c43 100644 > --- a/libavcodec/h264_picture.c > +++ b/libavcodec/h264_picture.c > @@ -80,6 +80,7 @@ static void h264_copy_picture_params(H264Picture *dst, const H264Picture *src) > dst->mbaff = src->mbaff; > dst->field_picture = src->field_picture; > dst->reference = src->reference; > + dst->picture_structure = src->picture_structure; > dst->recovered = src->recovered; > dst->invalid_gap = src->invalid_gap; > dst->sei_recovery_frame_cnt = src->sei_recovery_frame_cnt; > diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c > index 6188c74632..8ac66b343c 100644 > --- a/libavcodec/h264_slice.c > +++ b/libavcodec/h264_slice.c > @@ -491,6 +491,7 @@ static int h264_frame_start(H264Context *h) > pic->reference = h->droppable ? 0 : h->picture_structure; > pic->f->coded_picture_number = h->coded_picture_number++; > pic->field_picture = h->picture_structure != PICT_FRAME; > + pic->picture_structure = h->picture_structure; How does this make sense? picture_structure in slice header tells you whether you're currently decoding a frame or a field, but a decoded H264Picture is always a full frame (i.e. two fields). This code marks field-coded pictures as whatever the second coded field was. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".