From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 07C3E4574F for ; Mon, 20 Feb 2023 16:41:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C6FD168C023; Mon, 20 Feb 2023 18:41:07 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BF3ED68BFF0 for ; Mon, 20 Feb 2023 18:41:00 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 792182404EE for ; Mon, 20 Feb 2023 17:41:00 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id UE55iO4TCaWY for ; Mon, 20 Feb 2023 17:40:59 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id CCAC12404EC for ; Mon, 20 Feb 2023 17:40:59 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id B0E5F1601B2; Mon, 20 Feb 2023 17:40:59 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <74c58297-8429-dffe-91aa-3396ad78cebb@gyani.pro> References: <20230211110251.6726-1-ffmpeg@gyani.pro> <167636912532.10789.15401506923531612364@lain.khirnov.net> <0a6a12ae-c903-cbe9-5503-1299bbb66201@gyani.pro> <74c58297-8429-dffe-91aa-3396ad78cebb@gyani.pro> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 20 Feb 2023 17:40:59 +0100 Message-ID: <167691125969.10789.6689475644258922900@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avformat/flvenc: allow to write qualifying metadata as number X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Gyan Doshi (2023-02-19 09:13:55) > On 2023-02-14 06:21 pm, Gyan Doshi wrote: > > > > > > On 2023-02-14 03:35 pm, Anton Khirnov wrote: > >> Quoting Gyan Doshi (2023-02-11 12:02:51) > >>> The FLV format can store metadata as numbers which are used and handled > >>> by many streaming platforms. > >>> > >>> Now, metadata values can be sent as AMF Number type if > >>> 1) tag key starts with "num_" > >>> 2) value is scanned and can be represented as a double. > >>> > >>> Written tag will have "num_" prefix removed if written as AMF Number. > >> Using the normal metadata dict for structured data seems hacky to me. > >> Wouldn't it be better to add a private dict-type muxer option for this? > > > > The numerical metadata, like other string meta in FLV can change > > during streaming, so it will be > > reloaded and refreshed. Once you suggested to shift the loading > > metadata from file + reload options > > to fftools, this was the way to identify such metadata, since format > > contexts and AVStream only support > > one AVDictionary and entries will have to be commingled > > > > And this isn't really structured data. We are re-encoding how some of > > it is stored. It is still inputted > > by the user as strings. The prefix is a cheap hack to clearly identify > > such keys. > > > > (The other option would be add AVDictionary value 'types' and all > > associated signalling and tooling, > > which seems useful in the long run but overkill for this.) We have way too many hacks already, because everbody's looking for a quick solution and ignores longterm maintainability. I don't think this patch should go in. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".