From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 722574574D for ; Mon, 20 Feb 2023 16:29:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 46FCE68BFF6; Mon, 20 Feb 2023 18:29:14 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6113A68BF87 for ; Mon, 20 Feb 2023 18:29:07 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id CE7882404EE for ; Mon, 20 Feb 2023 17:29:06 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id WXiWDXxX-wI3 for ; Mon, 20 Feb 2023 17:29:05 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id BE1A42404EC for ; Mon, 20 Feb 2023 17:29:05 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 9E9941601B2; Mon, 20 Feb 2023 17:29:05 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230218044949.1179-2-ffmpeg@gyani.pro> References: <20230218044949.1179-1-ffmpeg@gyani.pro> <20230218044949.1179-2-ffmpeg@gyani.pro> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 20 Feb 2023 17:29:05 +0100 Message-ID: <167691054562.10789.13324315462801833907@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v4 2/5] avformat: add av_program_copy() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Gyan Doshi (2023-02-18 05:49:46) > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > index 33ab0bc8ba..46b4d177c3 100644 > --- a/libavformat/avformat.h > +++ b/libavformat/avformat.h > @@ -1886,6 +1886,28 @@ uint8_t *av_stream_get_side_data(const AVStream *stream, > > AVProgram *av_new_program(AVFormatContext *s, int id); > > +/** > + * Copy an AVProgram from one AVFormatContext to another. > + * > + * Streams in the destination context whose IDs match the IDs of the streams in the > + * source AVProgram index are added to the stream index of the copied AVProgram. > + * > + * If a new program has to be added, the function expects and requires any existing buffer > + * holding the array of pointers to AVPrograms in the destination context to have its size > + * be a power-of-two value. This should be the case if all earlier programs were created > + * using av_new_program or this function. > + * > + * @param dst pointer to the target muxer context > + * @param src pointer to the source muxer context > + * @param progid ID of the program to be copied > + * @param overwrite whether to overwrite if target muxer already > + * contains a program with the same ID > + * > + * @return >= 0 in case of success, a negative AVERROR code in case of > + * failure > + */ > +int av_program_copy(AVFormatContext *dst, const AVFormatContext *src, int progid, int overwrite); Why identify source programs by id rather than the structure itself? Also, overwrite should really be a more generic flags field for future extension. Overall I remain uneasy about this being public - the semantics are rather tricky and fragile unless the streams between src and dst match exactly. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".