From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 336D7452E7 for ; Fri, 17 Feb 2023 11:07:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 27D7568BE74; Fri, 17 Feb 2023 13:07:55 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E8BA7689965 for ; Fri, 17 Feb 2023 13:07:48 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id AF59F2404EE for ; Fri, 17 Feb 2023 12:07:48 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id AkAN5Z69vJms for ; Fri, 17 Feb 2023 12:07:48 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 13DF32404EC for ; Fri, 17 Feb 2023 12:07:48 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id EA7F81601B2; Fri, 17 Feb 2023 12:07:47 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <9135ef14-f767-095d-5ea6-40c9df9e0695@noa-archive.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 17 Feb 2023 12:07:47 +0100 Message-ID: <167663206793.1179.18261691439793810470@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] libavutil/log: Support for logging timestamps in the log X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Prakash (2023-02-17 01:16:04) > Moved the timestamp to the front (before loglevel but after the prefix if > present, so the timestamp has the same color as log line based on log > level). Updated the patch and attached again. > > > From 04857a7bf0d4cf24a479e795a55a61ab2e2f618e Mon Sep 17 00:00:00 2001 > From: Prakash Duggaraju > Date: Thu, 16 Feb 2023 16:06:29 -0800 > Subject: [PATCH] libavutil/log: Support for logging timestamps in the log. > Add > 'time' flag to the -loglevel option to turn on timestamp logging. Useful > for > troubleshooting where time is spent from the log files. > > Signed-off-by: Prakash Duggaraju > --- > doc/fftools-common-opts.texi | 4 ++++ > fftools/opt_common.c | 6 ++++++ > libavutil/log.c | 41 +++++++++++++++++++++++++----------- > libavutil/log.h | 8 +++++++ > 4 files changed, 47 insertions(+), 12 deletions(-) I do not like this patch. The default logging callback should be simple and straightforward, not a kitchen sink of all possible functionality. Callers who need this can and should implement this themselves. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".