* [FFmpeg-devel] [PATCH] ffmpeg_opt: move help text for -ab/-b:a to audio category
@ 2023-02-06 18:12 Marth64
2023-02-09 3:13 ` Anton Khirnov
0 siblings, 1 reply; 3+ messages in thread
From: Marth64 @ 2023-02-06 18:12 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Marth64
Since at least 4.4.3, -ab/-b:a help text was in the video section
of ffmpeg -h, but these are audio options.
Signed-off-by: Marth64 <marth64@proxyid.net>
---
fftools/ffmpeg_opt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index 204be38c94..799dcf071e 100644
--- a/fftools/ffmpeg_opt.c
+++ b/fftools/ffmpeg_opt.c
@@ -1637,8 +1637,6 @@ const OptionDef options[] = {
{ "force_key_frames", OPT_VIDEO | OPT_STRING | HAS_ARG | OPT_EXPERT |
OPT_SPEC | OPT_OUTPUT, { .off = OFFSET(forced_key_frames) },
"force key frames at specified timestamps", "timestamps" },
- { "ab", OPT_VIDEO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT, { .func_arg = opt_bitrate },
- "audio bitrate (please use -b:a)", "bitrate" },
{ "b", OPT_VIDEO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT, { .func_arg = opt_bitrate },
"video bitrate (please use -b:v)", "bitrate" },
{ "hwaccel", OPT_VIDEO | OPT_STRING | HAS_ARG | OPT_EXPERT |
@@ -1680,6 +1678,8 @@ const OptionDef options[] = {
{ "acodec", OPT_AUDIO | HAS_ARG | OPT_PERFILE |
OPT_INPUT | OPT_OUTPUT, { .func_arg = opt_audio_codec },
"force audio codec ('copy' to copy stream)", "codec" },
+ { "ab", OPT_AUDIO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT, { .func_arg = opt_bitrate },
+ "audio bitrate (please use -b:a)", "bitrate" },
{ "atag", OPT_AUDIO | HAS_ARG | OPT_EXPERT | OPT_PERFILE |
OPT_OUTPUT, { .func_arg = opt_old2new },
"force audio tag/fourcc", "fourcc/tag" },
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: move help text for -ab/-b:a to audio category
2023-02-06 18:12 [FFmpeg-devel] [PATCH] ffmpeg_opt: move help text for -ab/-b:a to audio category Marth64
@ 2023-02-09 3:13 ` Anton Khirnov
2023-02-09 4:49 ` Marth64
0 siblings, 1 reply; 3+ messages in thread
From: Anton Khirnov @ 2023-02-09 3:13 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Marth64
Quoting Marth64 (2023-02-06 19:12:15)
> Since at least 4.4.3, -ab/-b:a help text was in the video section
> of ffmpeg -h, but these are audio options.
>
> Signed-off-by: Marth64 <marth64@proxyid.net>
> ---
> fftools/ffmpeg_opt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
> index 204be38c94..799dcf071e 100644
> --- a/fftools/ffmpeg_opt.c
> +++ b/fftools/ffmpeg_opt.c
> @@ -1637,8 +1637,6 @@ const OptionDef options[] = {
> { "force_key_frames", OPT_VIDEO | OPT_STRING | HAS_ARG | OPT_EXPERT |
> OPT_SPEC | OPT_OUTPUT, { .off = OFFSET(forced_key_frames) },
> "force key frames at specified timestamps", "timestamps" },
> - { "ab", OPT_VIDEO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT, { .func_arg = opt_bitrate },
> - "audio bitrate (please use -b:a)", "bitrate" },
> { "b", OPT_VIDEO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT, { .func_arg = opt_bitrate },
> "video bitrate (please use -b:v)", "bitrate" },
> { "hwaccel", OPT_VIDEO | OPT_STRING | HAS_ARG | OPT_EXPERT |
> @@ -1680,6 +1678,8 @@ const OptionDef options[] = {
> { "acodec", OPT_AUDIO | HAS_ARG | OPT_PERFILE |
> OPT_INPUT | OPT_OUTPUT, { .func_arg = opt_audio_codec },
> "force audio codec ('copy' to copy stream)", "codec" },
> + { "ab", OPT_AUDIO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT, { .func_arg = opt_bitrate },
> + "audio bitrate (please use -b:a)", "bitrate" },
> { "atag", OPT_AUDIO | HAS_ARG | OPT_EXPERT | OPT_PERFILE |
> OPT_OUTPUT, { .func_arg = opt_old2new },
> "force audio tag/fourcc", "fourcc/tag" },
Looks ok, will push
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: move help text for -ab/-b:a to audio category
2023-02-09 3:13 ` Anton Khirnov
@ 2023-02-09 4:49 ` Marth64
0 siblings, 0 replies; 3+ messages in thread
From: Marth64 @ 2023-02-09 4:49 UTC (permalink / raw)
To: FFmpeg development discussions and patches, Marth64
Thank you
On Wed, Feb 8, 2023 at 9:13 PM Anton Khirnov <anton@khirnov.net> wrote:
> Quoting Marth64 (2023-02-06 19:12:15)
> > Since at least 4.4.3, -ab/-b:a help text was in the video section
> > of ffmpeg -h, but these are audio options.
> >
> > Signed-off-by: Marth64 <marth64@proxyid.net>
> > ---
> > fftools/ffmpeg_opt.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
> > index 204be38c94..799dcf071e 100644
> > --- a/fftools/ffmpeg_opt.c
> > +++ b/fftools/ffmpeg_opt.c
> > @@ -1637,8 +1637,6 @@ const OptionDef options[] = {
> > { "force_key_frames", OPT_VIDEO | OPT_STRING | HAS_ARG | OPT_EXPERT
> |
> > OPT_SPEC | OPT_OUTPUT,
> { .off = OFFSET(forced_key_frames) },
> > "force key frames at specified timestamps", "timestamps" },
> > - { "ab", OPT_VIDEO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT,
> { .func_arg = opt_bitrate },
> > - "audio bitrate (please use -b:a)", "bitrate" },
> > { "b", OPT_VIDEO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT,
> { .func_arg = opt_bitrate },
> > "video bitrate (please use -b:v)", "bitrate" },
> > { "hwaccel", OPT_VIDEO | OPT_STRING | HAS_ARG | OPT_EXPERT
> |
> > @@ -1680,6 +1678,8 @@ const OptionDef options[] = {
> > { "acodec", OPT_AUDIO | HAS_ARG | OPT_PERFILE |
> > OPT_INPUT | OPT_OUTPUT,
> { .func_arg = opt_audio_codec },
> > "force audio codec ('copy' to copy stream)", "codec" },
> > + { "ab", OPT_AUDIO | HAS_ARG | OPT_PERFILE |
> OPT_OUTPUT, { .func_arg = opt_bitrate },
> > + "audio bitrate (please use -b:a)", "bitrate" },
> > { "atag", OPT_AUDIO | HAS_ARG | OPT_EXPERT | OPT_PERFILE
> |
> > OPT_OUTPUT,
> { .func_arg = opt_old2new },
> > "force audio tag/fourcc", "fourcc/tag" },
>
> Looks ok, will push
>
> --
> Anton Khirnov
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-09 4:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-06 18:12 [FFmpeg-devel] [PATCH] ffmpeg_opt: move help text for -ab/-b:a to audio category Marth64
2023-02-09 3:13 ` Anton Khirnov
2023-02-09 4:49 ` Marth64
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git