From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8CF7241283 for ; Thu, 9 Feb 2023 03:13:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2076868BE57; Thu, 9 Feb 2023 05:13:30 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8845F68BCA8 for ; Thu, 9 Feb 2023 05:13:23 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 4C9552404EE; Thu, 9 Feb 2023 04:13:23 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id IhLMXQ1vVbHq; Thu, 9 Feb 2023 04:13:22 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 9F9382404EC; Thu, 9 Feb 2023 04:13:22 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 820F11601B2; Thu, 9 Feb 2023 04:13:22 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230206181215.2577927-1-marth64@proxyid.net> References: <20230206181215.2577927-1-marth64@proxyid.net> Mail-Followup-To: FFmpeg development discussions and patches , Marth64 Date: Thu, 09 Feb 2023 04:13:22 +0100 Message-ID: <167591240250.10789.4906950446642573791@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: move help text for -ab/-b:a to audio category X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marth64 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Marth64 (2023-02-06 19:12:15) > Since at least 4.4.3, -ab/-b:a help text was in the video section > of ffmpeg -h, but these are audio options. > > Signed-off-by: Marth64 > --- > fftools/ffmpeg_opt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c > index 204be38c94..799dcf071e 100644 > --- a/fftools/ffmpeg_opt.c > +++ b/fftools/ffmpeg_opt.c > @@ -1637,8 +1637,6 @@ const OptionDef options[] = { > { "force_key_frames", OPT_VIDEO | OPT_STRING | HAS_ARG | OPT_EXPERT | > OPT_SPEC | OPT_OUTPUT, { .off = OFFSET(forced_key_frames) }, > "force key frames at specified timestamps", "timestamps" }, > - { "ab", OPT_VIDEO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT, { .func_arg = opt_bitrate }, > - "audio bitrate (please use -b:a)", "bitrate" }, > { "b", OPT_VIDEO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT, { .func_arg = opt_bitrate }, > "video bitrate (please use -b:v)", "bitrate" }, > { "hwaccel", OPT_VIDEO | OPT_STRING | HAS_ARG | OPT_EXPERT | > @@ -1680,6 +1678,8 @@ const OptionDef options[] = { > { "acodec", OPT_AUDIO | HAS_ARG | OPT_PERFILE | > OPT_INPUT | OPT_OUTPUT, { .func_arg = opt_audio_codec }, > "force audio codec ('copy' to copy stream)", "codec" }, > + { "ab", OPT_AUDIO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT, { .func_arg = opt_bitrate }, > + "audio bitrate (please use -b:a)", "bitrate" }, > { "atag", OPT_AUDIO | HAS_ARG | OPT_EXPERT | OPT_PERFILE | > OPT_OUTPUT, { .func_arg = opt_old2new }, > "force audio tag/fourcc", "fourcc/tag" }, Looks ok, will push -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".