From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Marth64 <marth64@proxyid.net>
Subject: Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: move help text for -ab/-b:a to audio category
Date: Thu, 09 Feb 2023 04:13:22 +0100
Message-ID: <167591240250.10789.4906950446642573791@lain.khirnov.net> (raw)
In-Reply-To: <20230206181215.2577927-1-marth64@proxyid.net>
Quoting Marth64 (2023-02-06 19:12:15)
> Since at least 4.4.3, -ab/-b:a help text was in the video section
> of ffmpeg -h, but these are audio options.
>
> Signed-off-by: Marth64 <marth64@proxyid.net>
> ---
> fftools/ffmpeg_opt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
> index 204be38c94..799dcf071e 100644
> --- a/fftools/ffmpeg_opt.c
> +++ b/fftools/ffmpeg_opt.c
> @@ -1637,8 +1637,6 @@ const OptionDef options[] = {
> { "force_key_frames", OPT_VIDEO | OPT_STRING | HAS_ARG | OPT_EXPERT |
> OPT_SPEC | OPT_OUTPUT, { .off = OFFSET(forced_key_frames) },
> "force key frames at specified timestamps", "timestamps" },
> - { "ab", OPT_VIDEO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT, { .func_arg = opt_bitrate },
> - "audio bitrate (please use -b:a)", "bitrate" },
> { "b", OPT_VIDEO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT, { .func_arg = opt_bitrate },
> "video bitrate (please use -b:v)", "bitrate" },
> { "hwaccel", OPT_VIDEO | OPT_STRING | HAS_ARG | OPT_EXPERT |
> @@ -1680,6 +1678,8 @@ const OptionDef options[] = {
> { "acodec", OPT_AUDIO | HAS_ARG | OPT_PERFILE |
> OPT_INPUT | OPT_OUTPUT, { .func_arg = opt_audio_codec },
> "force audio codec ('copy' to copy stream)", "codec" },
> + { "ab", OPT_AUDIO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT, { .func_arg = opt_bitrate },
> + "audio bitrate (please use -b:a)", "bitrate" },
> { "atag", OPT_AUDIO | HAS_ARG | OPT_EXPERT | OPT_PERFILE |
> OPT_OUTPUT, { .func_arg = opt_old2new },
> "force audio tag/fourcc", "fourcc/tag" },
Looks ok, will push
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-02-09 3:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 18:12 Marth64
2023-02-09 3:13 ` Anton Khirnov [this message]
2023-02-09 4:49 ` Marth64
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167591240250.10789.4906950446642573791@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=marth64@proxyid.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git