From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1BD5B4418E for ; Thu, 2 Feb 2023 08:16:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4A1CE68B6B1; Thu, 2 Feb 2023 10:16:21 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E0A9868BB4D for ; Thu, 2 Feb 2023 10:16:14 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 22EB12404EC; Thu, 2 Feb 2023 09:16:14 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 9oFLKNxJ3EAw; Thu, 2 Feb 2023 09:16:08 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 86049240178; Thu, 2 Feb 2023 09:16:08 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 343801601B2; Thu, 2 Feb 2023 09:16:06 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20230128135818.387953-1-leo.izen@gmail.com> <20230202070208.1962086-1-quinkblack@foxmail.com> Mail-Followup-To: FFmpeg development discussions and patches , Zhao Zhili Date: Thu, 02 Feb 2023 09:16:06 +0100 Message-ID: <167532576618.13393.12797931957164785656@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH major bump 1/6] libavutil/hdr_dynamic_vivid_metadata: fix AVHDRVividColorToneMappingParams X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Zhao Zhili (2023-02-02 08:02:03) > From: Zhao Zhili > > There are two group of three_Spline params. Fix the struct > definition and usecases inside libavcodec, libavfilter and ffprobe. > > Co-Author: Houxiang ZHU > Signed-off-by: Zhao Zhili > --- > diff --git a/libavutil/hdr_dynamic_vivid_metadata.h b/libavutil/hdr_dynamic_vivid_metadata.h > index a34f83072c..4ceddc539d 100644 > --- a/libavutil/hdr_dynamic_vivid_metadata.h > +++ b/libavutil/hdr_dynamic_vivid_metadata.h > @@ -126,42 +126,42 @@ typedef struct AVHDRVividColorToneMappingParams { > * The mode of three Spline. the value shall be in the range > * of 0 to 3, inclusive. > */ > - int three_Spline_TH_mode; > + int three_Spline_TH_mode[2]; > > /** > * three_Spline_TH_enable_MB is in the range of 0.0 to 1.0, inclusive > * and in multiples of 1.0/255. > * > */ > - AVRational three_Spline_TH_enable_MB; > + AVRational three_Spline_TH_enable_MB[2]; > > /** > * 3Spline_TH_enable of three Spline. > * The value shall be in the range of 0.0 to 1.0, inclusive. > * and in multiples of 1.0/4095. > */ > - AVRational three_Spline_TH_enable; > + AVRational three_Spline_TH_enable[2]; > > /** > * 3Spline_TH_Delta1 of three Spline. > * The value shall be in the range of 0.0 to 0.25, inclusive, > * and in multiples of 0.25/1023. > */ > - AVRational three_Spline_TH_Delta1; > + AVRational three_Spline_TH_Delta1[2]; > > /** > * 3Spline_TH_Delta2 of three Spline. > * The value shall be in the range of 0.0 to 0.25, inclusive, > * and in multiples of 0.25/1023. > */ > - AVRational three_Spline_TH_Delta2; > + AVRational three_Spline_TH_Delta2[2]; > > /** > * 3Spline_enable_Strength of three Spline. > * The value shall be in the range of 0.0 to 1.0, inclusive, > * and in multiples of 1.0/255. > */ > - AVRational three_Spline_enable_Strength; > + AVRational three_Spline_enable_Strength[2]; > } AVHDRVividColorToneMappingParams; A major bump is not for breaking APIs however you like, only for things that were scheduled in advance that our callers could have prepared for. You should add new fields, not change existing ones. Also, the documentation and doc/APIchanges need to be updated. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".