From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C7D0545556 for ; Wed, 1 Feb 2023 07:02:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8E22768BE97; Wed, 1 Feb 2023 09:02:30 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 448AC68BE47 for ; Wed, 1 Feb 2023 09:02:24 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 5E5C52404EC for ; Wed, 1 Feb 2023 08:02:23 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id ohuXBKyGM3HK for ; Wed, 1 Feb 2023 08:02:20 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id CA151240178 for ; Wed, 1 Feb 2023 08:02:20 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id A9EBC1601B2; Wed, 1 Feb 2023 08:02:20 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20230120193132.21597-1-anton@khirnov.net> <20230120193132.21597-3-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 01 Feb 2023 08:02:20 +0100 Message-ID: <167523494066.4503.2538286790214421557@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 3/5] lavfi: add a new filtergraph parsing API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Nicolas George (2023-01-30 13:59:44) > > +static unsigned > > +find_linklabel(AVFilterGraphSegment *seg, const char *label, > > + int output, size_t idx_chain, size_t idx_filter, > > + AVFilterParams **pp) > > +{ > > + for (; idx_chain < seg->nb_chains; idx_chain++) { > > + AVFilterChain *ch = seg->chains[idx_chain]; > > + > > + for (; idx_filter < ch->nb_filters; idx_filter++) { > > + AVFilterParams *p = ch->filters[idx_filter]; > > + AVFilterPadParams **io = output ? p->outputs : p->inputs; > > + unsigned nb_io = output ? p->nb_outputs : p->nb_inputs; > > + AVFilterLink **l; > > + unsigned nb_l; > > + > > + if (!p->filter) > > + continue; > > + > > + l = output ? p->filter->outputs : p->filter->inputs; > > + nb_l = output ? p->filter->nb_outputs : p->filter->nb_inputs; > > + > > + for (unsigned i = 0; i < FFMIN(nb_io, nb_l); i++) > > + if (!l[i] && io[i]->label && !strcmp(io[i]->label, label)) { > > + *pp = p; > > + return i; > > + } > > + } > > + > > + idx_filter = 0; > > + } > > + > > + *pp = NULL; > > + return 0; > > +} > > If I read this code correctly, it will only find link labels that are > defined later in the chain or in a later chain. But referring to earlier > link labels is supported. Even cycles are meant to be supported at > parsing level (format negotiation will likely fail, though, but being > able to make cycles was a goal from the start). The earlier filters have already been processed at this point, so if an earlier filter had a link label that would match this one, then it's already been linked. So there's no point in considering earlier filters. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".