Re: [FFmpeg-devel] [PATCH] lavfi: get rid of FF_INTERNAL_FIELDS

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavfi: get rid of FF_INTERNAL_FIELDS
Date: Tue, 31 Jan 2023 15:18:28 +0100
Message-ID: <167517470800.4503.4882536660599256492@lain.khirnov.net> (raw)
In-Reply-To: <Y9kftqVrRRKxQ7Qo@phare.normalesup.org>

Quoting Nicolas George (2023-01-31 15:03:34)
> Anton Khirnov (12023-01-31):
> > I find this a significant improvement in code quality, making it easier
> > to maintain.
> 
> You can say that, you do not maintain it.

Do you?

You keep implying in your emails that you are the authority on lavfi,
but I see no objective support for this claim. MAINTAINERS only lists
you as the maintainer for graphdump.c and two filters.
And taken e.g. by the number of commits touching libavfilter/, mine is
similar to yours, and both are far behind other people.

> > - the most prolific lavfi contributor recently (Paul) has no objections
> >   to this patch
> > - the second most prolific lavfi contributor recently (Andreas) told me
> >   on IRC he planned to write this same patch himself
> 
> It is not a matter of volume, it is a matter of complexity. Since
> Stefano is no longer involved in the coding, I am the only one who knows
> how the tricky bits of libavfilter work.

Maybe someone should replace those tricky bits with something simpler
then.

> > So if you insist on objecting to this patch, it seems to me that a vote
> > would be in order.
> 
> Well, go ahead, but please be aware that a vote cannot force me to
> maintain that code.
> 
> If this project goes over my objections “that patch makes my maintenance
> work harder”, then be very careful to involve in your plans “find
> somebody else willing to debug the code of libavfilter”. Good luck.
> 
> In fact, I think I will take it very easy with maintenance duty until
> further notice. I am really fed up with the direction this project is
> taking. Authoritarianism, that was the other side of the fork, and we
> all know what happened there. And who is to blame.

Ah yes, preventing one person from enforcing his opinion over those of
multiple other people is "authoritarianism". I don't think that word
means what you think it means.

So take your pick - either stop opposing this patch or we have a vote
over it and see what other people think.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".