From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 79F4F4544D for ; Mon, 30 Jan 2023 07:56:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B9B2068BC2A; Mon, 30 Jan 2023 09:56:02 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 85F8C68B4A7 for ; Mon, 30 Jan 2023 09:55:55 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id E34EB2404EC; Mon, 30 Jan 2023 08:55:54 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id LhA6oHZrpT1W; Mon, 30 Jan 2023 08:55:54 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 4D469240178; Mon, 30 Jan 2023 08:55:54 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 15DE01601B2; Mon, 30 Jan 2023 08:55:52 +0100 (CET) From: Anton Khirnov To: ffmpeg-devel@ffmpeg.org, "Xiang, Haihao" In-Reply-To: <20230130052321.27566-1-haihao.xiang@intel.com> References: <20230130052321.27566-1-haihao.xiang@intel.com> Mail-Followup-To: ffmpeg-devel@ffmpeg.org, "Xiang, Haihao" Date: Mon, 30 Jan 2023 08:55:52 +0100 Message-ID: <167506535205.4503.8778082800087432409@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: fix segfault X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Xiang, Haihao (2023-01-30 06:23:21) > From: Haihao Xiang > > This is a regression since commit fbdba9a1a69fe4df413d9e9df1b11db522946e75 > > input_image is freed in vaapi_encode_wait() however it is still used in > commit fbdba9a1a69fe4df413d9e9df1b11db522946e75 > > $ ffmpeg -vaapi_device /dev/dri/renderD128 -f lavfi -i testsrc -vf > "format=nv12,hwupload" -c:v h264_vaapi -f null - > > Note input_image will be freed in vaapi_encode_free() now. > > Cc: Anton Khirnov > Signed-off-by: Haihao Xiang > --- > libavcodec/vaapi_encode.c | 3 --- > 1 file changed, 3 deletions(-) Thank you, looks good. Could swear I tested this, but apparently not :/ -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".