From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1707D45321 for ; Sat, 21 Jan 2023 16:54:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3505368BAA5; Sat, 21 Jan 2023 18:54:55 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 77B5668B71D for ; Sat, 21 Jan 2023 18:54:49 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 2F48E2404EC for ; Sat, 21 Jan 2023 17:54:49 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id ZYVB0vdnbtya for ; Sat, 21 Jan 2023 17:54:48 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 8FBFF240178 for ; Sat, 21 Jan 2023 17:54:48 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 72F321601B2; Sat, 21 Jan 2023 17:54:48 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <2f73f0fc-0e4c-edb8-649c-5446cc4c4ec0@gmail.com> References: <20230116133840.512-1-jamrial@gmail.com> <167407008302.4503.12911207010634660934@lain.khirnov.net> <2f73f0fc-0e4c-edb8-649c-5446cc4c4ec0@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Sat, 21 Jan 2023 17:54:48 +0100 Message-ID: <167432008843.26119.10866746375686741096@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Leo Izen (2023-01-20 22:23:23) > On 1/18/23 14:28, Anton Khirnov wrote: > > Quoting James Almer (2023-01-16 14:38:14) > >> It's been a while since the last bump, so it's time to do some cleaning and > >> remove deprecated APIs. This will also give us an "Open ABI season" in which we > >> can do breaking changes (like changing public struct offsets, public enum > >> values, adding fields to structs that have their size tied to the ABI, etc) for > >> a few weeks. > > > > Last time this open season lasted something like half a year and only > > ended when I arbitrarily said it did. > > > > So I'd suggest to decide right now how long will the instability period > > last (6 weeks should be enough for everybody) and write the end date at > > the top of doc/APIchanges. > > > > Another thing I'm not entirely happy about is versioning during the bump > > and instability. While the remove-then-bump approach does make bisection > > easier, it also creates commits that lie about their ABI version. > > > > If the bump comes before the resulting removals, then wouldn't the > removals strictly speaking exist inside the instability period as they > immediately follow a version bump? This sounds like it keeps our promise. With the way deprecation guards are typically structured, the bump itself disables all deprecated code atomically. The removals then just drop dead code. So even without an instability period this would work "correctly" and that's how I used to do it. However some people dislike so much code being disabled in a single commit, since that is harder to bisect if the bump introduces any issues.. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".