From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3B41F45317 for ; Fri, 20 Jan 2023 22:36:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3FBFA68BD3D; Sat, 21 Jan 2023 00:36:38 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0EC2B68BCEE for ; Sat, 21 Jan 2023 00:36:32 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id BE8782404EC for ; Fri, 20 Jan 2023 23:36:31 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id ejw_MbMqk6uW for ; Fri, 20 Jan 2023 23:36:31 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id F1186240178 for ; Fri, 20 Jan 2023 23:36:30 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id D1F0B1601B2; Fri, 20 Jan 2023 23:36:30 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20230120193132.21597-1-anton@khirnov.net> <20230120193132.21597-4-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 20 Jan 2023 23:36:30 +0100 Message-ID: <167425419081.4503.9038360869075401537@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 4/5] lavfi/graphparser: reimplement avfilter_graph_parse* using new API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Nicolas George (2023-01-20 21:47:16) > Anton Khirnov (12023-01-20): > > --- > > libavfilter/graphparser.c | 537 +++++++++----------------------------- > > 1 file changed, 126 insertions(+), 411 deletions(-) > > I notice you removed the "RFC" from the subject line, That means I now consider the code to be ready for a full review rather than just comments on the overall approach. > By the way, I am baffled that you would write a 30k+ patch on code you > do not maintain Does the graphparser have a maintainer? I did not notice. $ grep graphparser MAINTAINERS $ > and do not know well without consulting the maintainer > who knows it. Maybe it's the person who authored the most commits touching that file recently $ git shortlog -ns --since=2012 --no-merges origin/master libavfilter/graphparser.c 16 Anton Khirnov 8 Michael Niedermayer 4 Andreas Rheinhardt Or maybe we should consider avfilter.h too, since I'm adding new API $ git shortlog -ns --since=2012 --no-merges origin/master libavfilter/graphparser.c libavfilter/avfilter.h 73 Anton Khirnov 32 Nicolas George 23 Stefano Sabatini Hmm, now who could possibly be the person who knows that code? Any guesses? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".