From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3EECE4515A for ; Tue, 10 Jan 2023 11:07:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3BD1E68BD5C; Tue, 10 Jan 2023 13:07:33 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1B68D68B76F for ; Tue, 10 Jan 2023 13:07:27 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id CFB31240499 for ; Tue, 10 Jan 2023 12:07:26 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 5FcXsafhuV-h for ; Tue, 10 Jan 2023 12:07:26 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 4F59B2400F5 for ; Tue, 10 Jan 2023 12:07:26 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 31BE41601B2; Tue, 10 Jan 2023 12:07:26 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20221213024216.259-1-mindmark@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 10 Jan 2023 12:07:26 +0100 Message-ID: <167334884617.4503.15852706663666752299@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v3 1/4] avcodec/bswapdsp: remove unused cextern X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Mark Reid (2023-01-06 19:09:10) > On Mon, Dec 26, 2022 at 1:31 PM Mark Reid wrote: > > > > > > > On Mon, Dec 12, 2022 at 6:42 PM wrote: > > > >> From: Mark Reid > >> > >> --- > >> libavcodec/x86/bswapdsp.asm | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> diff --git a/libavcodec/x86/bswapdsp.asm b/libavcodec/x86/bswapdsp.asm > >> index 31c6c48a21..2aa235e13c 100644 > >> --- a/libavcodec/x86/bswapdsp.asm > >> +++ b/libavcodec/x86/bswapdsp.asm > >> @@ -26,8 +26,6 @@ > >> SECTION_RODATA > >> pb_bswap32: db 3, 2, 1, 0, 7, 6, 5, 4, 11, 10, 9, 8, 15, 14, 13, 12 > >> > >> -cextern pb_80 > >> - > >> SECTION .text > >> > >> ; %1 = aligned/unaligned > >> -- > >> 2.31.1.windows.1 > >> > >> > > ping > > > > ping Are you really duplicating a whole bunch of files from lavc in sws? I don't think that's anywhere remotely close to acceptable. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".