From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3 1/4] avcodec/bswapdsp: remove unused cextern
Date: Tue, 10 Jan 2023 12:07:26 +0100
Message-ID: <167334884617.4503.15852706663666752299@lain.khirnov.net> (raw)
In-Reply-To: <CA+anCRnAq+7b0AnfWC99-F0Vs03sSQswrQjDLxd9-eCVVGsGYA@mail.gmail.com>
Quoting Mark Reid (2023-01-06 19:09:10)
> On Mon, Dec 26, 2022 at 1:31 PM Mark Reid <mindmark@gmail.com> wrote:
>
> >
> >
> > On Mon, Dec 12, 2022 at 6:42 PM <mindmark@gmail.com> wrote:
> >
> >> From: Mark Reid <mindmark@gmail.com>
> >>
> >> ---
> >> libavcodec/x86/bswapdsp.asm | 2 --
> >> 1 file changed, 2 deletions(-)
> >>
> >> diff --git a/libavcodec/x86/bswapdsp.asm b/libavcodec/x86/bswapdsp.asm
> >> index 31c6c48a21..2aa235e13c 100644
> >> --- a/libavcodec/x86/bswapdsp.asm
> >> +++ b/libavcodec/x86/bswapdsp.asm
> >> @@ -26,8 +26,6 @@
> >> SECTION_RODATA
> >> pb_bswap32: db 3, 2, 1, 0, 7, 6, 5, 4, 11, 10, 9, 8, 15, 14, 13, 12
> >>
> >> -cextern pb_80
> >> -
> >> SECTION .text
> >>
> >> ; %1 = aligned/unaligned
> >> --
> >> 2.31.1.windows.1
> >>
> >>
> > ping
> >
>
> ping
Are you really duplicating a whole bunch of files from lavc in sws? I
don't think that's anywhere remotely close to acceptable.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-01-10 11:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 2:42 mindmark
2022-12-13 2:42 ` [FFmpeg-devel] [PATCH v3 2/4] avcodec/bswapdsp: rename bswap_buf to bswap_buf32 mindmark
2022-12-13 2:42 ` [FFmpeg-devel] [PATCH v3 3/4] avcodec/bswapdsp: add documentation mindmark
2022-12-13 2:42 ` [FFmpeg-devel] [PATCH v3 4/4] swscale/bswapdsp: copy over bswapdsp from avcodec mindmark
2022-12-26 21:31 ` [FFmpeg-devel] [PATCH v3 1/4] avcodec/bswapdsp: remove unused cextern Mark Reid
2023-01-06 18:09 ` Mark Reid
2023-01-10 11:07 ` Anton Khirnov [this message]
2023-01-10 22:57 ` Mark Reid
2023-01-13 20:04 ` Rémi Denis-Courmont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167334884617.4503.15852706663666752299@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git