From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4CC2345157 for ; Tue, 10 Jan 2023 11:02:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C139468BD55; Tue, 10 Jan 2023 13:02:34 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5B39D680677 for ; Tue, 10 Jan 2023 13:02:28 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id A6C03240499 for ; Tue, 10 Jan 2023 12:02:27 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id kVjEVBuxz-gc for ; Tue, 10 Jan 2023 12:02:27 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 03D8D2400F5 for ; Tue, 10 Jan 2023 12:02:27 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id D9CE91601B2; Tue, 10 Jan 2023 12:02:26 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230103102217.1074-1-ffmpeg@gyani.pro> References: <20230103102217.1074-1-ffmpeg@gyani.pro> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 10 Jan 2023 12:02:26 +0100 Message-ID: <167334854686.4503.11919708033955040353@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] ffmpeg: apply discontinuity adjustment per-stream X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Gyan Doshi (2023-01-03 11:22:17) > At present, the offset for discontinuity adjustment is applied per-file but > the check for discontinuity is intra-stream so the same discontinuity when > seen in multiple streams with copyts, leads to compounded adjustment of the > discontinuity offset. This introduces gaps in streams, leading to loss of sync > or even de facto loss of stream. > > The ts_offset_discont parameter is transferred to InputStream and adjusted > based on intra-stream gaps. I never had much use for this feature, but I wonder if adding different offsets to different streams isn't going against the whole point of timestamps, which is synchronizing them. Also, this could REALLY use tests. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".