From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 40DB7450AB for ; Thu, 5 Jan 2023 11:10:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ACF1B68BCEB; Thu, 5 Jan 2023 13:10:01 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EF80E68BCBB for ; Thu, 5 Jan 2023 13:09:54 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id B606E240499 for ; Thu, 5 Jan 2023 12:09:54 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 12rrhuUWV_Tt for ; Thu, 5 Jan 2023 12:09:54 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 343422400F5 for ; Thu, 5 Jan 2023 12:09:54 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 2308F1601B2; Thu, 5 Jan 2023 12:09:54 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230105004645.GA4028235@pb2> References: <20230104164246.6133-1-anton@khirnov.net> <20230104164246.6133-2-anton@khirnov.net> <20230105004645.GA4028235@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 05 Jan 2023 12:09:54 +0100 Message-ID: <167291699410.26119.15264968194066746719@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/8] fftools/ffmpeg: stop using AVCodecContext.sample_rate in decode_audio() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2023-01-05 01:46:45) > On Wed, Jan 04, 2023 at 05:42:40PM +0100, Anton Khirnov wrote: > > Use the decoded frame's sample_rate instead, which is the authoritative > > value. > > > > Drop a now-obsolete check validating AVCodecContext.sample_rate. > > --- > > fftools/ffmpeg.c | 15 ++++++--------- > > 1 file changed, 6 insertions(+), 9 deletions(-) > > Causes division by 0 > will send you the sample privately Should be fixed in the patchset I just sent. IMO lavc returning invalid frames is a bug that should be fixed in lavc, so this patch should still go in. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".