From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A8299450A0 for ; Wed, 4 Jan 2023 17:41:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8A73E68BBCB; Wed, 4 Jan 2023 19:41:42 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7249668BBCB for ; Wed, 4 Jan 2023 19:41:36 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 10902240499 for ; Wed, 4 Jan 2023 18:41:36 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id MGaW0J5yBQhF for ; Wed, 4 Jan 2023 18:41:35 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 871972400F5 for ; Wed, 4 Jan 2023 18:41:35 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 677C71601B2; Wed, 4 Jan 2023 18:41:35 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20230104164246.6133-1-anton@khirnov.net> <20230104164246.6133-8-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 04 Jan 2023 18:41:35 +0100 Message-ID: <167285409539.4503.2013344141160875953@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 8/8] fftools/ffmpeg: always generate CFR output when -r is used X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Paul B Mahol (2023-01-04 18:37:31) > On Wed, Jan 4, 2023 at 5:46 PM Anton Khirnov wrote: > > > Current code may, depending on the muxer, decide to use VSYNC_VFR tagged > > with the specified framerate, without actually performing framerate > > conversion. This is clearly wrong and against the documentation, which > > states unambiguously that -r should produce CFR output for video > > encoding. > > > > FATE test changes: > > * nuv-rtjpeg: replace -r with '-enc_time_base -1', which keeps the > > original timebase. Output frames are now produced with proper > > durations. > > * filter-mpdecimate: just drop the -r option, it is unnecessary > > * filter-fps-r: remove, this test makes no sense and actually > > produces broken VFR output (with incorrect frame durations). > > > > With this patch or even before? With current master, so without the patch. After the patch it starts producing proper CFR, but is then redundant with fate-filter-fps-cfr. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".