From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A398044A84 for ; Tue, 6 Dec 2022 14:43:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C4EDB68BD55; Tue, 6 Dec 2022 16:43:07 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AF2AD68BD26 for ; Tue, 6 Dec 2022 16:43:01 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 703DB240499 for ; Tue, 6 Dec 2022 15:43:01 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id zztJMnFJcWq3 for ; Tue, 6 Dec 2022 15:43:00 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id E56BC2400F5 for ; Tue, 6 Dec 2022 15:43:00 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id C8F191601B2; Tue, 6 Dec 2022 15:43:00 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20221205133938.505-1-timo@rothenpieler.org> <167033742725.26119.15040760416331150943@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 06 Dec 2022 15:43:00 +0100 Message-ID: <167033778079.26119.6038146894846925847@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/thread: add support for frame threading receive_frame based decoders X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Timo Rothenpieler (2022-12-06 15:39:50) > On 06/12/2022 15:37, Anton Khirnov wrote: > > Quoting Timo Rothenpieler (2022-12-05 14:39:37) > >> This is fairly basic and makes a lot of assumptions, but it works > >> for the most simple cases. > >> > >> For one, it only ever fetches exactly one packet per call to receive_frame. > >> Right now it's impossible for there to ever be more than one, but the API > >> allows for more, which might need handled in the future. > >> > >> It also basically translates the new API back to the old, since that's how > >> the frame threading code operates. Which feels backwards in regards to > >> the new API, but it was the path with least resistance in implementing this. > > > > If it only supports one packet to one frame, then it goes against the > > whole point of using the receive_frame API. > > Otherwise the entirety of pthread_frame.c would need rewritten from > scratch. It has that assumption coded into it. I told you on IRC I already have a mostly-finished branch that implements threading with receive_frame(), so I don't really understand what's the point of your writing this patch. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".