From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4D2F5422B5 for ; Tue, 29 Nov 2022 11:14:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3021E68B8CC; Tue, 29 Nov 2022 13:14:10 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4972C68A65A for ; Tue, 29 Nov 2022 13:14:04 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 0201B240499; Tue, 29 Nov 2022 12:14:03 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 7vi4Cy7tevo1; Tue, 29 Nov 2022 12:14:02 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 51AFD2400F5; Tue, 29 Nov 2022 12:14:02 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 11A0C1601B2; Tue, 29 Nov 2022 12:14:00 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20221116114306.251999-1-leo.izen@gmail.com> References: <20221116114306.251999-1-leo.izen@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches , Leo Izen Date: Tue, 29 Nov 2022 12:14:00 +0100 Message-ID: <166972044003.4503.6154057733583441158@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/pnm: avoid mirroring PFM images vertically X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Leo Izen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Leo Izen (2022-11-16 12:43:06) > PFM (aka Portable FloatMap) encodes its scanlines from bottom-to-top, > not from top-to-bottom, unlike other NetPBM formats. Without this > patch, FFmpeg ignores this exception and decodes/encodes PFM images > mirrored vertically from their proper orientation. > > For reference, see the NetPBM tool pfmtopam, which encodes a .pam > from a .pfm, using the correct orientation (and which FFmpeg reads > correctly). Also compare ffplay to magick display, which shows the > correct orientation as well. > > See: http://www.pauldebevec.com/Research/HDR/PFM/ and see: > https://netpbm.sourceforge.net/doc/pfm.html for descriptions of this > image format. > > Signed-off-by: Leo Izen > --- > libavcodec/pnmdec.c | 10 ++++++++++ > libavcodec/pnmenc.c | 18 ++++++++++-------- > tests/ref/lavf/gbrpf32be.pfm | 2 +- > tests/ref/lavf/gbrpf32le.pfm | 2 +- > tests/ref/lavf/grayf32be.pfm | 2 +- > tests/ref/lavf/grayf32le.pfm | 2 +- > 6 files changed, 24 insertions(+), 12 deletions(-) Looks reasonable, will push soonish. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".