From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Mark Reid <mindmark@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/tiff: add read support for compressed rgb floating point formats
Date: Mon, 14 Nov 2022 17:50:37 +0100
Message-ID: <166844463730.20155.11752407594406089870@lain.khirnov.net> (raw)
In-Reply-To: <20221001230512.271-1-mindmark@gmail.com>
Quoting mindmark@gmail.com (2022-10-02 01:05:12)
> From: Mark Reid <mindmark@gmail.com>
>
> floating point uses a slightly different predictor technique describe here
> http://chriscox.org/TIFFTN3d1.pdf
>
> Here is a link the test files, if someone could add them to fate me
> https://www.dropbox.com/s/fg59h2os4gb4wug/tiff_fate_samples.zip
>
>
> ---
> libavcodec/tiff.c | 68 ++++++++++++++++++++++
> tests/fate/image.mak | 20 ++++++-
> tests/ref/fate/tiff-lzw-rgbaf32le | 6 ++
> tests/ref/fate/tiff-lzw-rgbf32le | 6 ++
> tests/ref/fate/tiff-uncompressed-rgbaf32le | 6 ++
> tests/ref/fate/tiff-uncompressed-rgbf32le | 6 ++
> tests/ref/fate/tiff-zip-rgbaf32le | 6 ++
> tests/ref/fate/tiff-zip-rgbf32le | 6 ++
> 8 files changed, 123 insertions(+), 1 deletion(-)
> create mode 100644 tests/ref/fate/tiff-lzw-rgbaf32le
> create mode 100644 tests/ref/fate/tiff-lzw-rgbf32le
> create mode 100644 tests/ref/fate/tiff-uncompressed-rgbaf32le
> create mode 100644 tests/ref/fate/tiff-uncompressed-rgbf32le
> create mode 100644 tests/ref/fate/tiff-zip-rgbaf32le
> create mode 100644 tests/ref/fate/tiff-zip-rgbf32le
Looks acceptable, will push in a few days if nobody objects.
But decode_frame() is starting to look very long and smelly and could
definitely use some refactoring.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-11-14 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 23:05 mindmark
2022-10-02 17:06 ` Michael Niedermayer
2022-10-02 17:18 ` James Almer
2022-10-20 16:49 ` Mark Reid
2022-11-01 3:17 ` Mark Reid
2022-11-14 16:50 ` Anton Khirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166844463730.20155.11752407594406089870@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=mindmark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git