From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7109544C43 for ; Mon, 14 Nov 2022 09:53:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 87E2E68BD62; Mon, 14 Nov 2022 11:53:07 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A417E68B44A for ; Mon, 14 Nov 2022 11:53:01 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 4F36F240499 for ; Mon, 14 Nov 2022 10:53:01 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id Fi0TJzbHGOrV for ; Mon, 14 Nov 2022 10:53:00 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 8DDD02400F5 for ; Mon, 14 Nov 2022 10:53:00 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 7B9FA1601B2; Mon, 14 Nov 2022 10:53:00 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: =?utf-8?q?=3CDM8P223MB0365D8B9C3D10EDB607F5C72BA059=40DM8P223MB?= =?utf-8?q?0365=2ENAMP223=2EPROD=2EOUTLOOK=2ECOM=3E?= References: <20221114091309.15755-1-anton@khirnov.net> <20221114091309.15755-2-anton@khirnov.net> =?utf-8?q?=3CDM8P223MB0365D8B9C3?= =?utf-8?q?D10EDB607F5C72BA059=40DM8P223MB0365=2ENAMP223=2EPROD=2EOUTLOOK=2E?= =?utf-8?q?COM=3E?= Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 14 Nov 2022 10:53:00 +0100 Message-ID: <166841958047.1198.11408751838101496304@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/4] doc/developer.texi: extend the argument for submitting patches X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Soft Works (2022-11-14 10:35:40) > > > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of > > Anton Khirnov > > Sent: Monday, November 14, 2022 10:13 AM > > To: ffmpeg-devel@ffmpeg.org > > Subject: [FFmpeg-devel] [PATCH 2/4] doc/developer.texi: extend the > > argument for submitting patches > > > > Stop talking about commercial programs, since this applies to any > > downstream user. > > --- > > doc/developer.texi | 20 +++++++++++++++----- > > 1 file changed, 15 insertions(+), 5 deletions(-) > > > > diff --git a/doc/developer.texi b/doc/developer.texi > > index 5cf3b19ee0..2f0d2b7daa 100644 > > --- a/doc/developer.texi > > +++ b/doc/developer.texi > > @@ -24,11 +24,21 @@ generated from the headers > > the examples under @file{doc/examples} > > @end itemize > > > > -You can use the FFmpeg libraries in your commercial program, but you > > -are encouraged to @emph{publish any patch you make}. In this case > > the > > -best way to proceed is to send your patches to the ffmpeg-devel > > -mailing list following the guidelines illustrated in the remainder > > of > > -this document. > > +If you modify FFmpeg code for your own use case, you are highly > > encouraged to > > +@emph{submit your changes back to us}, using this document as a > > guide. There are > > +both pragmatic and ideological reasons to do so: > > +@itemize @bullet > > +@item > > +Maintaining external changes to keep up with upstream development is > > +time-consuming and error-prone. With your code in the main tree, it > > will be > > +maintained by FFmpeg developers. > > You should mention that sometimes it's not really worth to take the effort, > because waiting for reviews and permanent rebasing and re-submitting, > explaining, defending, getting insulted or ignored and whatsoever, > might end up taking much more time than just to keep and maintain your > changes privately. Eventually you might regret that you have even > started going that way. Sorry, but you problems are entirely self-inflicted. You have been told what changes need to happen right from the beginning, repeatedly, and by several developers independently. Instead of implementing them you chose to compose ever-more-elaborate explanations and justifications that, as far as I can tell, boil down to "doing things properly is too much work". Seems to me that actually doing this work would take less time than you have already spent arguing. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".