From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EFED144C3B for ; Mon, 14 Nov 2022 09:24:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 24AC168BD7B; Mon, 14 Nov 2022 11:24:03 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9A18268BC4A for ; Mon, 14 Nov 2022 11:23:56 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 56E8C240499 for ; Mon, 14 Nov 2022 10:23:56 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id wXvYm6uxFDSG for ; Mon, 14 Nov 2022 10:23:55 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id B70642400F5 for ; Mon, 14 Nov 2022 10:23:55 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 687951601B2; Mon, 14 Nov 2022 10:23:53 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20221110195233.GD1814017@pb2> References: <20221108112550.8375-1-anton@khirnov.net> <20221108112550.8375-2-anton@khirnov.net> <20221110122827.GZ1814017@pb2> <166808350478.1198.18430086573897178566@lain.khirnov.net> <20221110195233.GD1814017@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 14 Nov 2022 10:23:53 +0100 Message-ID: <166841783339.20155.4932866616536129385@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/5] lavf/demux: treat EAGAIN as REDO unless AVFMT_FLAG_NONBLOCK is set X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2022-11-10 20:52:33) > On Thu, Nov 10, 2022 at 01:31:44PM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2022-11-10 13:28:27) > > > On Tue, Nov 08, 2022 at 12:25:47PM +0100, Anton Khirnov wrote: > > > > Lavf only supports a very limited approximation of non-blocking > > > > behavior, so we should not return random EAGAINs to callers unless they > > > > specifically requested it. > > > > --- > > > > libavformat/demux.c | 8 ++++++-- > > > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > > > this changes seeking behavior of for example: > > > libavformat/tests/seek fate-suite/dss/sp.dss > > > > > > (this seemed to return EAGAIN before sometimes) > > > > Are you saying that is wrong? I don't see why seeks should return EAGAIN > > either. > > I do not know if its wrong or not. I remember some seeking used error > returns to switch to generic seeking and such stuff. > I just reporrted this as i saw a difference in the tests/seek output AFAICT the differences are only in av_read_frame() calls, which no longer return EAGAIN. That is exactly what this patch is supposed to do, so I'd say there is no problem. If noone has further objections, I'll push this patch soonish. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".