From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Marvin Scholz <epirat07@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH v2 2/5] avutil/dict: Use av_dict_iterate in av_dict_get
Date: Tue, 25 Oct 2022 11:46:49 +0200
Message-ID: <166669120901.12287.16027307494397949836@lain.khirnov.net> (raw)
In-Reply-To: <20220924143659.74756-2-epirat07@gmail.com>
Quoting Marvin Scholz (2022-09-24 16:36:56)
> ---
> libavutil/dict.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/libavutil/dict.c b/libavutil/dict.c
> index ee059d712c..ea03590d0f 100644
> --- a/libavutil/dict.c
> +++ b/libavutil/dict.c
> @@ -60,18 +60,14 @@ const AVDictionaryEntry *av_dict_iterate(const AVDictionary *m,
> AVDictionaryEntry *av_dict_get(const AVDictionary *m, const char *key,
> const AVDictionaryEntry *prev, int flags)
> {
> - unsigned int i, j;
> + const AVDictionaryEntry *entry = prev;
Broken indentation, otherwise looks good.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-10-25 9:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 2:02 [FFmpeg-devel] [PATCH 1/2] avutil/dict: Add av_dict_iterate Marvin Scholz
2022-09-22 2:02 ` [FFmpeg-devel] [PATCH 2/2] avutil/dict: Use av_dict_iterate in av_dict_get Marvin Scholz
2022-09-22 11:33 ` [FFmpeg-devel] [PATCH 1/2] avutil/dict: Add av_dict_iterate Andreas Rheinhardt
2022-09-22 11:47 ` Marvin Scholz
2022-09-22 11:56 ` Andreas Rheinhardt
2022-09-24 14:36 ` [FFmpeg-devel] [PATCH v2 1/5] " Marvin Scholz
2022-09-24 14:36 ` [FFmpeg-devel] [PATCH v2 2/5] avutil/dict: Use av_dict_iterate in av_dict_get Marvin Scholz
2022-10-25 9:46 ` Anton Khirnov [this message]
2022-09-24 14:36 ` [FFmpeg-devel] [PATCH v2 3/5] avutil/dict: Use av_dict_iterate in av_dict_copy Marvin Scholz
2022-09-24 14:36 ` [FFmpeg-devel] [PATCH v2 4/5] avutil/dict: Use av_dict_iterate in av_dict_get_string Marvin Scholz
2022-09-24 14:36 ` [FFmpeg-devel] [PATCH v2 5/5] avutil/dict: Improve documentation Marvin Scholz
2022-10-11 13:23 ` [FFmpeg-devel] [PATCH v2 1/5] avutil/dict: Add av_dict_iterate Marvin Scholz
2022-10-25 9:41 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166669120901.12287.16027307494397949836@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=epirat07@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git