From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id B7D8B402CE
	for <ffmpegdev@gitmailbox.com>; Mon, 17 Oct 2022 13:01:26 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8E38A68BCF3;
	Mon, 17 Oct 2022 16:01:23 +0300 (EEST)
Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7F55E68BCCA
 for <ffmpeg-devel@ffmpeg.org>; Mon, 17 Oct 2022 16:01:17 +0300 (EEST)
Received: from localhost (localhost [IPv6:::1])
 by mail0.khirnov.net (Postfix) with ESMTP id 8B7D12404E4
 for <ffmpeg-devel@ffmpeg.org>; Mon, 17 Oct 2022 15:01:16 +0200 (CEST)
Received: from mail0.khirnov.net ([IPv6:::1])
 by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024)
 with ESMTP id PwskhTSgpKib for <ffmpeg-devel@ffmpeg.org>;
 Mon, 17 Oct 2022 15:01:16 +0200 (CEST)
Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK))
 by mail0.khirnov.net (Postfix) with ESMTPS id 254252400F4
 for <ffmpeg-devel@ffmpeg.org>; Mon, 17 Oct 2022 15:01:16 +0200 (CEST)
Received: by lain.khirnov.net (Postfix, from userid 1000)
 id C2ACF1601B2; Mon, 17 Oct 2022 15:01:13 +0200 (CEST)
From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <e005d815-f6d4-a8ac-42d0-faf03fbbb0aa@mail.de>
References: <20220926055753.88407-1-thilo.borgmann@mail.de>
 <20220926055753.88407-2-thilo.borgmann@mail.de>
 <166487305168.5794.17571588681688773816@lain.khirnov.net>
 <e005d815-f6d4-a8ac-42d0-faf03fbbb0aa@mail.de>
Mail-Followup-To: FFmpeg development discussions and patches
 <ffmpeg-devel@ffmpeg.org>
Date: Mon, 17 Oct 2022 15:01:13 +0200
Message-ID: <166601167377.5707.8544639446487597345@lain.khirnov.net>
User-Agent: alot/0.8.1
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH v6 1/2] ffmpeg: Add display_{rotation,
 hflip, vflip} options
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/166601167377.5707.8544639446487597345@lain.khirnov.net/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Quoting Thilo Borgmann (2022-10-15 12:27:54)
> 
> av_stream_new_side_data() returns uint8_t*.
> 
> So it is either add a cast to if(...) or two casts to av_display_...().

Better to have one cast than two.
(I also prefer to avoid assignments inside conditions, but not going to
bitch about this very strongly now)

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".