From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Guangyu Sun <gsun@roblox.com>
Subject: Re: [FFmpeg-devel] [PATCH v2] lavf/async: Fix ring_write return value
Date: Thu, 13 Oct 2022 16:55:34 +0200
Message-ID: <166567293440.12287.13332999270754301647@lain.khirnov.net> (raw)
In-Reply-To: <20220929181134.93922-1-gsun@roblox.com>
Quoting Guangyu Sun (2022-09-29 20:11:34)
> his fixes a regression from commit 36117968ad.
>
> wrapped_url_read() used to be able to return positive number from
> ffurl_read(). It relies on the result to check if EOF is reached in
> async_buffer_task().
>
> But FIFO callbacks must return 0 on success. This should be handled
> in ring_write() instead.
>
> Test case:
> ffmpeg -f lavfi -i testsrc -t 1 test.mp4
> ffmpeg -i async:test.mp4
>
> Signed-off-by: Guangyu Sun <gsun@roblox.com>
> ---
> libavformat/async.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Thank you, will push.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-10-13 14:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 5:22 [FFmpeg-devel] [PATCH] lavf/async: Fix wrapped_url_read " Guangyu Sun
2022-09-28 14:08 ` Anton Khirnov
2022-09-29 18:11 ` [FFmpeg-devel] [PATCH v2] lavf/async: Fix ring_write " Guangyu Sun
2022-10-13 14:55 ` Anton Khirnov [this message]
2022-09-29 18:15 ` [FFmpeg-devel] [PATCH] lavf/async: Fix wrapped_url_read " Guangyu Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166567293440.12287.13332999270754301647@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=gsun@roblox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git