From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2D02D44465 for ; Wed, 12 Oct 2022 17:30:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0B74268BD2D; Wed, 12 Oct 2022 20:30:06 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B208A68BBB9 for ; Wed, 12 Oct 2022 20:29:59 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id E89352404E4 for ; Wed, 12 Oct 2022 19:29:58 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id LboSo7_tLLyR for ; Wed, 12 Oct 2022 19:29:55 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id F281D2400F4 for ; Wed, 12 Oct 2022 19:29:54 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 34B571601B2; Wed, 12 Oct 2022 19:29:55 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20221004153909.GD2046395@pb2> References: <20221004095630.869044100EF@natalya.videolan.org> <20221004153909.GD2046395@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 12 Oct 2022 19:29:55 +0200 Message-ID: <166559579518.12287.14303175428898589326@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: drop the -async option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2022-10-04 17:39:09) > On Tue, Oct 04, 2022 at 09:56:29AM +0000, Anton Khirnov wrote: > > ffmpeg | branch: master | Anton Khirnov | Tue Aug 30 11:14:13 2022 +0200| [3d86a13b47b726e49c2d780c5f723c290e8a36b4] | committer: Anton Khirnov > > > > fftools/ffmpeg: drop the -async option > > > > It has been deprecated in favor of the aresample filter for almost 10 > > years. > > > > Another thing this option can do is drop audio timestamps and have them > > generated by the encoding code or the muxer, but > > - for encoding, this can already be done with the setpts filter > > - for muxing this should almost never be done as timestamp generation by > > the muxer is deprecated, but people who really want to do this can use > > the setts bitstream filter > > > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=3d86a13b47b726e49c2d780c5f723c290e8a36b4 > > --- > > > > doc/ffmpeg.texi | 12 ------------ > > fftools/ffmpeg.c | 2 +- > > fftools/ffmpeg.h | 1 - > > fftools/ffmpeg_filter.c | 10 ---------- > > fftools/ffmpeg_mux.c | 3 +-- > > fftools/ffmpeg_opt.c | 3 --- > > 6 files changed, 2 insertions(+), 29 deletions(-) > > This breaks: > ./ffmpeg -i ~/tickets/507/avdesync_cut.avi -bitexact -r 24000/1001 -t 145 -async 1 file1-old.avi > > The file is no longer AV-synced after this, and iam not sure the user > will understand why > its not warning or erroring out either I suppose we could print a warning when swr options are specified, but no resample filter is present. But then whether it is or is not present can change at runtime, so not sure that's a good solution. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".