From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E933544460 for ; Wed, 12 Oct 2022 17:08:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7156F68BD36; Wed, 12 Oct 2022 20:08:22 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9CEEE68BC0E for ; Wed, 12 Oct 2022 20:08:16 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 370452404E4 for ; Wed, 12 Oct 2022 19:08:16 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id DFGoZ3Z05uve for ; Wed, 12 Oct 2022 19:08:15 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id AC7E12400F4 for ; Wed, 12 Oct 2022 19:08:15 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id BB6F41601B2; Wed, 12 Oct 2022 19:08:15 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <0cf6becc-14d4-ef7e-4685-bd812b5e91ba@gmail.com> References: <20221007145942.880-1-ovchinnikov.dmitrii@gmail.com> <0cf6becc-14d4-ef7e-4685-bd812b5e91ba@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 12 Oct 2022 19:08:15 +0200 Message-ID: <166559449573.12287.7130178455796872334@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [crop support for matroska demuxer, V3 1/3] libavcodec: Add crop related fields to structure AVCodecContext and AVCodecParameters. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2022-10-11 14:51:34) > On 10/11/2022 9:43 AM, Timo Rothenpieler wrote: > > I really don't like seeing this in avcodec. > > Why does an encoder or decoder need to care about this, given it's > > container level information? > > > > Do you plan on implementing cropping support into all the encoders? > > This should be handled via an avfilter, which might get the cropping > > info from the demuxer via site data or something. > > There's logic in decode.c to apply bitstream level cropping (like in > h264). This could be extended to also apply container level cropping > exported as packet side data, like you suggested. That logic is essentially just calling av_frame_apply_cropping(). Callers can just as easily do this themselves; adding a bunch of new fields and a system of policies seems like unnecessary complexity that cannot provide all the flexibility one might want anyway. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".