From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [crop support for matroska demuxer, V3 1/3] libavcodec: Add crop related fields to structure AVCodecContext and AVCodecParameters.
Date: Wed, 12 Oct 2022 19:08:15 +0200
Message-ID: <166559449573.12287.7130178455796872334@lain.khirnov.net> (raw)
In-Reply-To: <0cf6becc-14d4-ef7e-4685-bd812b5e91ba@gmail.com>
Quoting James Almer (2022-10-11 14:51:34)
> On 10/11/2022 9:43 AM, Timo Rothenpieler wrote:
> > I really don't like seeing this in avcodec.
> > Why does an encoder or decoder need to care about this, given it's
> > container level information?
> >
> > Do you plan on implementing cropping support into all the encoders?
> > This should be handled via an avfilter, which might get the cropping
> > info from the demuxer via site data or something.
>
> There's logic in decode.c to apply bitstream level cropping (like in
> h264). This could be extended to also apply container level cropping
> exported as packet side data, like you suggested.
That logic is essentially just calling av_frame_apply_cropping().
Callers can just as easily do this themselves; adding a bunch of new
fields and a system of policies seems like unnecessary complexity that
cannot provide all the flexibility one might want anyway.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-10-12 17:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 14:59 OvchinnikovDmitrii
2022-10-07 14:59 ` [FFmpeg-devel] [crop support for matroska demuxer, V3 2/3] libavcodec: Public code to support container crop OvchinnikovDmitrii
2022-10-07 14:59 ` [FFmpeg-devel] [crop support for matroska demuxer, V3 3/3] libavformat\matroskadec.c: crop support for matroska demuxer OvchinnikovDmitrii
2022-10-11 11:59 ` [FFmpeg-devel] [crop support for matroska demuxer, V3 1/3] libavcodec: Add crop related fields to structure AVCodecContext and AVCodecParameters Anton Khirnov
2022-10-12 15:20 ` Dmitrii Ovchinnikov
2022-10-11 12:43 ` Timo Rothenpieler
2022-10-11 12:51 ` James Almer
2022-10-12 17:08 ` Anton Khirnov [this message]
2022-10-12 15:21 ` Dmitrii Ovchinnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166559449573.12287.7130178455796872334@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git