From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D658344413 for ; Tue, 11 Oct 2022 11:59:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 517E068BC23; Tue, 11 Oct 2022 14:59:26 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0895468BB99 for ; Tue, 11 Oct 2022 14:59:19 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 5CAFC2404E4; Tue, 11 Oct 2022 13:59:18 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 4a5Kf7kSB1QN; Tue, 11 Oct 2022 13:59:17 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id BB3972400F4; Tue, 11 Oct 2022 13:59:17 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 541091601B2; Tue, 11 Oct 2022 13:59:15 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20221007145942.880-1-ovchinnikov.dmitrii@gmail.com> References: <20221007145942.880-1-ovchinnikov.dmitrii@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches , OvchinnikovDmitrii Date: Tue, 11 Oct 2022 13:59:15 +0200 Message-ID: <166548955531.5794.12476590707197899360@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [crop support for matroska demuxer, V3 1/3] libavcodec: Add crop related fields to structure AVCodecContext and AVCodecParameters. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: OvchinnikovDmitrii Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting OvchinnikovDmitrii (2022-10-07 16:59:40) > --- > libavcodec/avcodec.h | 35 +++++++++++++++++++++++++++++++++++ > libavcodec/codec_par.h | 8 ++++++++ > libavcodec/options_table.h | 4 ++++ > 3 files changed, 47 insertions(+) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index 7365eb5cc0..d28a7cc022 100644 > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcodec.h > @@ -380,6 +380,19 @@ typedef struct RcOverride{ > */ > #define AV_GET_ENCODE_BUFFER_FLAG_REF (1 << 0) > > +/** > +* Video decoding only. Certain container support cropping, meaning that > +* only a sub-rectangle of the decoded frame is intended for display. > +* Certain codec supports cropping as well.This option controls how > +* cropping is handled by libavcodec when container cropping and > +* codec cropping exist. > +*/ > +enum CONTAINER_CROPPING_POLICY_TYPE { > + FF_CONTAINER_CROPPING_IGNORE = 0, > + FF_CONTAINER_CROPPING_ADDITION, > + FF_CONTAINER_CROPPING_OVERWRITE > +}; > + > struct AVCodecInternal; > > /** > @@ -2057,6 +2070,28 @@ typedef struct AVCodecContext { > * The decoder can then override during decoding as needed. > */ > AVChannelLayout ch_layout; > + > + /* When set to 1 (the default), libavcodec will apply container cropping > + * to codec cropping additionally. > + * > + * When set to 2, libavcodec will use container cropping to overwrite > + * codec cropping (the final cropping uses container cropping parameters) > + * > + * When set to 0, libavcodec will ignore container cropping parameters > + * (the final cropping uses codec cropping parameters) > + * > + * This field works with "apply_cropping". Only if apply_cropping is 1, this > + * field works > + */ > + enum CONTAINER_CROPPING_POLICY_TYPE container_apply_cropping; > + > + /** > + * The cropping parameters from container. > + */ > + int container_crop_top; > + int container_crop_left; > + int container_crop_bottom; > + int container_crop_right; I don't see why should a decoder deal with this at all? This can be just as well done by the caller. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".