From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2A0A14426E for ; Tue, 4 Oct 2022 11:36:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 73EA768BC0C; Tue, 4 Oct 2022 14:36:01 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0CC1C68B61A for ; Tue, 4 Oct 2022 14:35:55 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id BCD472404E4 for ; Tue, 4 Oct 2022 13:35:54 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id kRECqRBmv_xi for ; Tue, 4 Oct 2022 13:35:54 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 494BC2400F4 for ; Tue, 4 Oct 2022 13:35:54 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 57A7A1601B2; Tue, 4 Oct 2022 13:35:54 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20221001061341.662-1-ovchinnikov.dmitrii@gmail.com> <20221001061341.662-2-ovchinnikov.dmitrii@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 04 Oct 2022 13:35:54 +0200 Message-ID: <166488335433.5794.2147914860904019226@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [crop support for matroska demuxer 2/3] libavcodec: Public code to support container crop X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Hendrik Leppkes (2022-10-01 09:16:20) > Somehow I don't feel like adding the two crops together is really > going to do what most users would expect to happen. It just feels > weird. > It also changes the decoder crop information, and an API user does not > get the pure information from the decoder, but rather an "interpreted" > form. As an API user, I do not get the ability here to extract the > pure decoder crop info, unless I manually null out the container info > beforehand, or subtract it again, both of which seems odd and > undesirable to me. Shouldn't I be provided with clean information, and > then I (the API user) can choose how to act? I agree, such policy decisions belong in the caller, not our libraries. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".