From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C136444266 for ; Tue, 4 Oct 2022 09:37:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AADEF68BC15; Tue, 4 Oct 2022 12:36:56 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3840568BBFC for ; Tue, 4 Oct 2022 12:36:50 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id AA7202404E4 for ; Tue, 4 Oct 2022 11:36:49 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id Iuzc_88FJja9 for ; Tue, 4 Oct 2022 11:36:49 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 141312400F4 for ; Tue, 4 Oct 2022 11:36:49 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 180601601B2; Tue, 4 Oct 2022 11:36:49 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <5f92999c-2097-5016-daff-7ecddbfac1f3@passwd.hu> References: <20220928093213.947-1-anton@khirnov.net> <5f92999c-2097-5016-daff-7ecddbfac1f3@passwd.hu> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 04 Oct 2022 11:36:49 +0200 Message-ID: <166487620906.5794.5456148015950663376@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/3] lavc/encode: make sure frame timebase matches encoder, when set X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Marton Balint (2022-09-28 21:54:11) > > > On Wed, 28 Sep 2022, Anton Khirnov wrote: > > > AVFrame.time_base has been added recently, but is currently not used for > > anything. Prepare for its use in encoders by rejecting frames where > > time_base is set, but differs from the AVCodecContext one. > > How is that not an API break? Users can encode AVFrames with anything in > the AVFrame->time_base right now, if you change that behaviour, that will > surely break some code. That is why it was explicitly documented that > it will be ignored by encoders by default. Why would there be anything in that field? No code we have currently sets that field or does anything with it. There is no valid reason for the users to be setting it on the frames they send to lavc. As for "it would have worked before', there are many precedents where some nonsensical parameter combination would "work", but then we'd add a check and it would start returning errors. Callers should not be setting random fields to random values and expect things to work. Would applying this patch after a major bump alleviate your concerns? We wanted to have one for a few months already. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".