From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5B6F643A26 for ; Tue, 4 Oct 2022 09:01:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7F39768B423; Tue, 4 Oct 2022 12:01:09 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1B77268B423 for ; Tue, 4 Oct 2022 12:01:03 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 601E72404E4; Tue, 4 Oct 2022 11:01:02 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id ZQU02BZWIqgw; Tue, 4 Oct 2022 11:01:01 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id D915A2400F4; Tue, 4 Oct 2022 11:01:01 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 3420D1601B2; Tue, 4 Oct 2022 11:01:02 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20220925042841.522188-1-quinkblack@foxmail.com> Mail-Followup-To: FFmpeg development discussions and patches , Zhao Zhili Date: Tue, 04 Oct 2022 11:01:02 +0200 Message-ID: <166487406219.5794.14623134260464156379@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/mp3dec: remove a call to avio_tell() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Zhao Zhili (2022-09-25 06:28:41) > From: Zhao Zhili > > --- > libavformat/mp3dec.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c > index a9e494452d..05c13228bc 100644 > --- a/libavformat/mp3dec.c > +++ b/libavformat/mp3dec.c > @@ -424,15 +424,14 @@ static int mp3_read_header(AVFormatContext *s) > } > } > if (i == 64 * 1024) { > - ret = avio_seek(s->pb, off, SEEK_SET); > + off = avio_seek(s->pb, off, SEEK_SET); > } else { > av_log(s, i > 0 ? AV_LOG_INFO : AV_LOG_VERBOSE, "Skipping %d bytes of junk at %"PRId64".\n", i, off); > - ret = avio_seek(s->pb, off + i, SEEK_SET); > + off = avio_seek(s->pb, off + i, SEEK_SET); > } > - if (ret < 0) > - return ret; > + if (off < 0) > + return off; > > - off = avio_tell(s->pb); Looks ok. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".