From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8905640B2C for ; Tue, 4 Oct 2022 08:52:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D401168BBFE; Tue, 4 Oct 2022 11:52:26 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 24BA568BBC4 for ; Tue, 4 Oct 2022 11:52:20 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 768902404E4 for ; Tue, 4 Oct 2022 10:52:19 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id Kc2BBNlIlWR7 for ; Tue, 4 Oct 2022 10:52:19 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id ECB412400F4 for ; Tue, 4 Oct 2022 10:52:18 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 412501601B2; Tue, 4 Oct 2022 10:52:19 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20220926055753.88407-3-thilo.borgmann@mail.de> References: <20220926055753.88407-1-thilo.borgmann@mail.de> <20220926055753.88407-3-thilo.borgmann@mail.de> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 04 Oct 2022 10:52:19 +0200 Message-ID: <166487353924.5794.1206954245791109304@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v6 2/2] ffmpeg: Deprecate display rotation override with a metadata key X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Thilo Borgmann (2022-09-26 07:57:53) > diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c > index f07858333d..3f2409ee28 100644 > --- a/fftools/ffmpeg_opt.c > +++ b/fftools/ffmpeg_opt.c > @@ -2859,16 +2859,26 @@ static void of_add_metadata(AVFormatContext *oc, const OptionsContext *o) > for (int j = 0; j < oc->nb_streams; j++) { > OutputStream *ost = output_streams[nb_output_streams - oc->nb_streams + j]; > if ((ret = check_stream_specifier(oc, oc->streams[j], stream_spec)) > 0) { > +#if FFMPEG_ROTATION_METADATA > if (!strcmp(o->metadata[i].u.str, "rotate")) { > char *tail; > double theta = av_strtod(val, &tail); > if (!*tail) { > ost->rotate_overridden = 1; > ost->rotate_override_value = theta; > + > + av_log(NULL, AV_LOG_WARNING, > + "Conversion of a 'rotate' metadata key to a " > + "proper display matrix rotation is deprecated. " Also, the user has no idea what a "proper display matrix rotation" is. Make it something like "Using 'rotate' metadata to specify rotation is deprecated. > + "See -display_rotation for setting rotation " > + "instead."); Missing newline. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".