From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5CDF442BFD for ; Fri, 30 Sep 2022 14:15:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BD3A168BBA3; Fri, 30 Sep 2022 17:15:34 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4A99568BA9B for ; Fri, 30 Sep 2022 17:15:28 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id B5731240183; Fri, 30 Sep 2022 16:15:26 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 6yM-SM34UfC0; Fri, 30 Sep 2022 16:15:26 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 05B112400F4; Fri, 30 Sep 2022 16:15:26 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 04B9B1601B2; Fri, 30 Sep 2022 16:15:23 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches , Chema Gonzalez In-Reply-To: References: <20220926161122.1352372-1-chemag@gmail.com> <166437777511.22057.15424129912103570657@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches , Chema Gonzalez Date: Fri, 30 Sep 2022 16:15:22 +0200 Message-ID: <166454732298.22057.17402846782495941013@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/1] libswscale: force a minimum size of the slide for bayer sources X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Chema Gonzalez (2022-09-28 18:20:22) > Hi, > > On Wed, Sep 28, 2022 at 8:09 AM Anton Khirnov wrote: > > > if (isBayer(srcFormat)) { > > > + c->dst_slice_align = 2; > > > > IMO it's better to put this next to the line that sets dst_slice_align > > for non-bayer cases, makes it clearer what the final value is. > Are you suggesting setting `dst_slice_align` in a different function? > > The way I read `ff_get_unscaled_swscale()` is that it goes through the > quirks of all the different conversions (per source and destination > type). In all cases, it sets the `convert_unscaled` function pointer. > In the cases where there is the need to align (yuv2bgr and > yuv410p_to_yuv[a]420p), it also adds `dst_slice_align`. In the same > fashion, the conversions that affect Bayer sources are set in line > 2097. I suppose it depends on whether you consider the required alignment a fundamental property of the pixel format or a specific property of the chosen conversion kernel. My first hunch would be the former, but I guess your argument is valid as well. Anybody else also has an opinion? If not, I can push your patch as is. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".