Re: [FFmpeg-devel] [PATCH 1/1] libswscale: force a minimum size of the slide for bayer sources

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches
	<ffmpeg-devel@ffmpeg.org>, Chema Gonzalez <chemag@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH 1/1] libswscale: force a minimum size of the slide for bayer sources
Date: Fri, 30 Sep 2022 16:15:22 +0200
Message-ID: <166454732298.22057.17402846782495941013@lain.khirnov.net> (raw)
In-Reply-To: <CAEb0MfeQLqScBby48fMVHjdzngqb6z41rokOL_GvrRFOSNgUng@mail.gmail.com>

Quoting Chema Gonzalez (2022-09-28 18:20:22)
> Hi,
> 
> On Wed, Sep 28, 2022 at 8:09 AM Anton Khirnov <anton@khirnov.net> wrote:
> > >      if (isBayer(srcFormat)) {
> > > +        c->dst_slice_align = 2;
> >
> > IMO it's better to put this next to the line that sets dst_slice_align
> > for non-bayer cases, makes it clearer what the final value is.
> Are you suggesting setting `dst_slice_align` in a different function?
> 
> The way I read `ff_get_unscaled_swscale()` is that it goes through the
> quirks of all the different conversions (per source and destination
> type). In all cases, it sets the `convert_unscaled` function pointer.
> In the cases where there is the need to align (yuv2bgr and
> yuv410p_to_yuv[a]420p), it also adds `dst_slice_align`. In the same
> fashion, the conversions that affect Bayer sources are set in line
> 2097.

I suppose it depends on whether you consider the required alignment a
fundamental property of the pixel format or a specific property of the
chosen conversion kernel. My first hunch would be the former, but I
guess your argument is valid as well.

Anybody else also has an opinion? If not, I can push your patch as is.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".