From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id BC8F5449B5
	for <ffmpegdev@gitmailbox.com>; Wed, 28 Sep 2022 15:39:12 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A0F7968BB99;
	Wed, 28 Sep 2022 18:39:09 +0300 (EEST)
Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 670F868BB4E
 for <ffmpeg-devel@ffmpeg.org>; Wed, 28 Sep 2022 18:39:02 +0300 (EEST)
Received: from localhost (localhost [IPv6:::1])
 by mail0.khirnov.net (Postfix) with ESMTP id E54E6240183
 for <ffmpeg-devel@ffmpeg.org>; Wed, 28 Sep 2022 17:39:01 +0200 (CEST)
Received: from mail0.khirnov.net ([IPv6:::1])
 by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024)
 with ESMTP id 202sDm4T0pnd for <ffmpeg-devel@ffmpeg.org>;
 Wed, 28 Sep 2022 17:39:01 +0200 (CEST)
Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK))
 by mail0.khirnov.net (Postfix) with ESMTPS id 5E22B2400F4
 for <ffmpeg-devel@ffmpeg.org>; Wed, 28 Sep 2022 17:39:01 +0200 (CEST)
Received: by lain.khirnov.net (Postfix, from userid 1000)
 id 8B5DA1601B2; Wed, 28 Sep 2022 17:39:01 +0200 (CEST)
From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <011a0421-e70a-37b3-b9f8-e9015f3622e7@gmail.com>
References: <20220830014653.2477-1-jamrial@gmail.com>
 <20220905010955.173-1-jamrial@gmail.com>
 <166393837176.26932.2149159917577069121@lain.khirnov.net>
 <011a0421-e70a-37b3-b9f8-e9015f3622e7@gmail.com>
Mail-Followup-To: FFmpeg development discussions and patches
 <ffmpeg-devel@ffmpeg.org>
Date: Wed, 28 Sep 2022 17:39:01 +0200
Message-ID: <166437954153.22057.8153803257117804608@lain.khirnov.net>
User-Agent: alot/0.8.1
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH] avcodec: add a bsf to reorder DTS into
 PTS
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/166437954153.22057.8153803257117804608@lain.khirnov.net/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Quoting James Almer (2022-09-23 16:27:32)
> On 9/23/2022 10:06 AM, Anton Khirnov wrote:
> >> +static int dts2pts_filter(AVBSFContext *ctx, AVPacket *out)
> >> +{
> >> +    DTS2PTSContext *s = ctx->priv_data;
> >> +    DTS2PTSNode *poc_node = NULL, *next[2] = { NULL, NULL };
> >> +    DTS2PTSFrame frame;
> >> +    int ret;
> >> +
> >> +    // Fill up the FIFO and POC tree
> >> +    if (!s->eof && av_fifo_can_write(s->fifo)) {
> > 
> > More than one packet can be available, so this should probably be a
> > loop.
> 
> What do you mean? AVBSFContext can contain at most one buffered packet.

I'd prefer if filters didn't make any such assumptions.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".