From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec: add a bsf to reorder DTS into PTS
Date: Wed, 28 Sep 2022 17:39:01 +0200
Message-ID: <166437954153.22057.8153803257117804608@lain.khirnov.net> (raw)
In-Reply-To: <011a0421-e70a-37b3-b9f8-e9015f3622e7@gmail.com>
Quoting James Almer (2022-09-23 16:27:32)
> On 9/23/2022 10:06 AM, Anton Khirnov wrote:
> >> +static int dts2pts_filter(AVBSFContext *ctx, AVPacket *out)
> >> +{
> >> + DTS2PTSContext *s = ctx->priv_data;
> >> + DTS2PTSNode *poc_node = NULL, *next[2] = { NULL, NULL };
> >> + DTS2PTSFrame frame;
> >> + int ret;
> >> +
> >> + // Fill up the FIFO and POC tree
> >> + if (!s->eof && av_fifo_can_write(s->fifo)) {
> >
> > More than one packet can be available, so this should probably be a
> > loop.
>
> What do you mean? AVBSFContext can contain at most one buffered packet.
I'd prefer if filters didn't make any such assumptions.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-09-28 15:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 1:46 James Almer
2022-08-30 14:30 ` Andreas Rheinhardt
2022-08-30 15:26 ` James Almer
2022-08-30 17:07 ` Andreas Rheinhardt
2022-09-05 1:09 ` James Almer
2022-09-23 13:06 ` Anton Khirnov
2022-09-23 14:27 ` James Almer
2022-09-28 15:39 ` Anton Khirnov [this message]
2022-10-04 1:58 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166437954153.22057.8153803257117804608@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git