Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: configure min_hard_comp unconditionally

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Zhao Zhili <zhilizhao@tencent.com>
Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: configure min_hard_comp unconditionally
Date: Thu, 22 Sep 2022 17:41:35 +0200
Message-ID: <166386129532.26932.8733609294837354450@lain.khirnov.net> (raw)
In-Reply-To: <tencent_8134033E4F56719C8CE0305BD434D781A609@qq.com>

Quoting Zhao Zhili (2022-09-17 06:30:01)
> From: Zhao Zhili <zhilizhao@tencent.com>
> 
> There are two issues here. Firstly, the floating-point comparison
> is always true. Seconly, the code depends on the default value of
> min_hard_comp implicitly, which can be dangerous.
> 
> Partially fixes ticket 9859.
> ---
>  fftools/ffmpeg_filter.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c
> index 7a5308425d..17928cea2c 100644
> --- a/fftools/ffmpeg_filter.c
> +++ b/fftools/ffmpeg_filter.c
> @@ -896,8 +896,7 @@ static int configure_input_audio_filter(FilterGraph *fg, InputFilter *ifilter,
>          char args[256] = {0};
>  
>          av_strlcatf(args, sizeof(args), "async=%d", audio_sync_method);
> -        if (audio_drift_threshold != 0.1)
> -            av_strlcatf(args, sizeof(args), ":min_hard_comp=%f", audio_drift_threshold);
> +        av_strlcatf(args, sizeof(args), ":min_hard_comp=%f", audio_drift_threshold);

ok

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".