From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 90991442E3 for ; Mon, 5 Sep 2022 05:59:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C82D368B7AB; Mon, 5 Sep 2022 08:59:23 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 19C0A68B6CC for ; Mon, 5 Sep 2022 08:59:17 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id B188C240D0E for ; Mon, 5 Sep 2022 07:59:16 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 53pO9F7dO_Vh for ; Mon, 5 Sep 2022 07:59:16 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 34118240D03 for ; Mon, 5 Sep 2022 07:59:16 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 3E60E1601B2; Mon, 5 Sep 2022 07:59:16 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: =?utf-8?q?=3CDM8P223MB03651F44AF0CB13A516C4C52BA7C9=40DM8P223MB?= =?utf-8?q?0365=2ENAMP223=2EPROD=2EOUTLOOK=2ECOM=3E?= References: <20220901233236.GP2088045@pb2> <166227470363.5707.5961328202531700226@lain.khirnov.net> =?utf-8?q?=3CDM8P2?= =?utf-8?q?23MB03651F44AF0CB13A516C4C52BA7C9=40DM8P223MB0365=2ENAMP223=2EPRO?= =?utf-8?q?D=2EOUTLOOK=2ECOM=3E?= Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 05 Sep 2022 07:59:16 +0200 Message-ID: <166235755622.3205.11723035588545989440@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [RFC] d3dva security hw+threads X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Soft Works (2022-09-04 09:43:36) > > > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of > > Anton Khirnov > > Sent: Sunday, September 4, 2022 8:58 AM > > To: FFmpeg development discussions and patches > devel@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [RFC] d3dva security hw+threads > > > > Quoting Timo Rothenpieler (2022-09-02 01:46:59) > > > On 02.09.2022 01:32, Michael Niedermayer wrote: > > > > Hi all > > > > > > > > Theres a use after free issue in H.264 Decoding on d3d11va with > > multiple threads > > > > I dont have the hardware/platform nor do i know the hw decoding > > code so i made > > > > no attempt to fix this beyond asking others to ... > > > > > > hwaccel with multiple threads being broken is not exactly a > > surprise. > > > So we could just disable that, and always have it be one single > > thread? > > > > We are already disabling it in a way - the frame threading code > > ensures > > that threads run one at a time when hwaccel is being used. > > > Is there a described way to repro? I would try whether it still > happens after removing the lock code in hwcontext_d3d11va.c. > Those locks are not really needed and might prevent release > of dx11 resources in proper order. It's a guess only but > easy to try. The problem is not in d3d11 locking code, but in the generic code that does not have clear enough ownership rules. Steve already tested that my patch from Friday fixes this. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".