From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8FA8C441F8 for ; Fri, 2 Sep 2022 07:11:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3817368B9DD; Fri, 2 Sep 2022 10:11:34 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 634DA68B9DC for ; Fri, 2 Sep 2022 10:11:27 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 2029D240D0E for ; Fri, 2 Sep 2022 09:11:27 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id EXyhwAj4vB9e for ; Fri, 2 Sep 2022 09:11:26 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 71EAD240D03 for ; Fri, 2 Sep 2022 09:11:26 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 607FA1601B2; Fri, 2 Sep 2022 09:11:26 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20220901223436.GO2088045@pb2> References: <20220613001021.8065-1-michael@niedermayer.cc> <20220613001021.8065-3-michael@niedermayer.cc> <20220613215521.GH396728@pb2> <20220613220959.GI396728@pb2> <20220712182018.GO396728@pb2> <20220901223436.GO2088045@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 02 Sep 2022 09:11:26 +0200 Message-ID: <166210268636.3205.8231228595948965514@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 3/3] avcodec/bink: disallow odd positioned scaled blocks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2022-09-02 00:34:36) > On Tue, Jul 12, 2022 at 08:20:18PM +0200, Michael Niedermayer wrote: > > On Tue, Jun 14, 2022 at 12:09:59AM +0200, Michael Niedermayer wrote: > > > On Tue, Jun 14, 2022 at 12:01:14AM +0200, Paul B Mahol wrote: > > > > On Mon, Jun 13, 2022 at 11:55 PM Michael Niedermayer > > > > wrote: > > > > > > > > > On Mon, Jun 13, 2022 at 10:02:24AM +0200, Paul B Mahol wrote: > > > > > > Have you checked this with longer samples? > > > > > > > > > > ive tested it with the files in the bink directory on samples > > > > > anything else i should test it with ? > > > > > > > > > > > > > Something longer, where is big gap between keyframes. > > > > > > I would have thought that some of the 46 files in the samples archieve > > > would have adequate gaps. > > > Can you share some better test file ? > > > > ping ? > > anyone has more files i should test ? > > if not, i suggest to apply this > > google will publish this report in 5 days > just a reminder this is a out of array write and it will be very easily > searchable so anyone looking for unfixed bugs to exploit will try to > exploit this Then push the patch and see if anyone comes up with any samples. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".