Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/3] avcodec/bink: disallow odd positioned scaled blocks
Date: Fri, 02 Sep 2022 09:11:26 +0200
Message-ID: <166210268636.3205.8231228595948965514@lain.khirnov.net> (raw)
In-Reply-To: <20220901223436.GO2088045@pb2>

Quoting Michael Niedermayer (2022-09-02 00:34:36)
> On Tue, Jul 12, 2022 at 08:20:18PM +0200, Michael Niedermayer wrote:
> > On Tue, Jun 14, 2022 at 12:09:59AM +0200, Michael Niedermayer wrote:
> > > On Tue, Jun 14, 2022 at 12:01:14AM +0200, Paul B Mahol wrote:
> > > > On Mon, Jun 13, 2022 at 11:55 PM Michael Niedermayer <michael@niedermayer.cc>
> > > > wrote:
> > > > 
> > > > > On Mon, Jun 13, 2022 at 10:02:24AM +0200, Paul B Mahol wrote:
> > > > > > Have you checked this with longer samples?
> > > > >
> > > > > ive tested it with the files in the bink directory on samples
> > > > > anything else i should test it with ?
> > > > >
> > > > 
> > > > Something longer, where is big gap between keyframes.
> > > 
> > > I would have thought that some of the 46 files in the samples archieve
> > > would have adequate gaps.
> > > Can you share some better test file ?
> > 
> > ping ?
> > anyone has more files i should test ?
> > if not, i suggest to apply this
> 
> google will publish this report in 5 days
> just a reminder this is a out of array write and it will be very easily
> searchable so anyone looking for unfixed bugs to exploit will try to
> exploit this

Then push the patch and see if anyone comes up with any samples.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-09-02  7:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13  0:10 [FFmpeg-devel] [PATCH 1/3] tools/target_dec_fuzzer: Adjust threshold for SIMBIOSIS_IMX Michael Niedermayer
2022-06-13  0:10 ` [FFmpeg-devel] [PATCH 2/3] avformat/mov: Check the item count in iloc better Michael Niedermayer
2022-06-13  0:10 ` [FFmpeg-devel] [PATCH 3/3] avcodec/bink: disallow odd positioned scaled blocks Michael Niedermayer
2022-06-13  8:02   ` Paul B Mahol
2022-06-13 21:55     ` Michael Niedermayer
2022-06-13 22:01       ` Paul B Mahol
2022-06-13 22:09         ` Michael Niedermayer
2022-07-12 18:20           ` Michael Niedermayer
2022-09-01 22:34             ` Michael Niedermayer
2022-09-02  7:11               ` Anton Khirnov [this message]
2022-09-02  8:01                 ` Michael Niedermayer
2022-07-07 18:40 ` [FFmpeg-devel] [PATCH 1/3] tools/target_dec_fuzzer: Adjust threshold for SIMBIOSIS_IMX Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166210268636.3205.8231228595948965514@lain.khirnov.net \
    --to=anton@khirnov.net \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git