From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4C6E84407B for ; Thu, 25 Aug 2022 09:55:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1C12668B9DD; Thu, 25 Aug 2022 12:55:51 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C16FA68B8FC for ; Thu, 25 Aug 2022 12:55:44 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 21A42240D0E for ; Thu, 25 Aug 2022 11:55:44 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id PUzDHh2oVh1H for ; Thu, 25 Aug 2022 11:55:42 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id B8A20240D03 for ; Thu, 25 Aug 2022 11:55:42 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 08BD21601B2; Thu, 25 Aug 2022 11:55:43 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <166142090708.3205.14041488037220405132@lain.khirnov.net> References: <20220824084318.333-1-anton@khirnov.net> <20220824084318.333-5-anton@khirnov.net> =?utf-8?q?=3CDB6PR0101MB22149F226C?= =?utf-8?q?AAF4BB5B2208BF8F739=40DB6PR0101MB2214=2Eeurprd01=2Eprod=2Eexchang?= =?utf-8?q?elabs=2Ecom=3E?= <166142090708.3205.14041488037220405132@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 25 Aug 2022 11:55:43 +0200 Message-ID: <166142134300.3205.2243600771551073974@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 05/18] lavc/dv: remove ff_dvvideo_init() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Anton Khirnov (2022-08-25 11:48:27) > Quoting Andreas Rheinhardt (2022-08-24 14:27:43) > > There is actually another issue here: Encoders are not supposed to set > > chroma_sample_location at all according to the documentation. I sent a > > patch to implement this > > (https://ffmpeg.org/pipermail/ffmpeg-devel/2022-July/298518.html -- it > > also inlines and removes ff_dvvideo_init()), but I am unsure whether it > > is not the documentation that needs to be updated. > > I would say update the documentation. It does make sense for encoders to > set this field. Or on second thought, maybe no. Apparently no other encoders set it. Though we might want to check whether the value matches and warn/error out otherwise. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".