From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 05/18] lavc/dv: remove ff_dvvideo_init()
Date: Thu, 25 Aug 2022 11:55:43 +0200
Message-ID: <166142134300.3205.2243600771551073974@lain.khirnov.net> (raw)
In-Reply-To: <166142090708.3205.14041488037220405132@lain.khirnov.net>
Quoting Anton Khirnov (2022-08-25 11:48:27)
> Quoting Andreas Rheinhardt (2022-08-24 14:27:43)
> > There is actually another issue here: Encoders are not supposed to set
> > chroma_sample_location at all according to the documentation. I sent a
> > patch to implement this
> > (https://ffmpeg.org/pipermail/ffmpeg-devel/2022-July/298518.html -- it
> > also inlines and removes ff_dvvideo_init()), but I am unsure whether it
> > is not the documentation that needs to be updated.
>
> I would say update the documentation. It does make sense for encoders to
> set this field.
Or on second thought, maybe no. Apparently no other encoders set it.
Though we might want to check whether the value matches and warn/error
out otherwise.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-08-25 9:55 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 8:43 [FFmpeg-devel] [PATCH 01/18] tests/fate/mov: add a test for dv audio demuxed through dv demuxer Anton Khirnov
2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 02/18] lavf/dv: remove DVMuxContext declaration from dv.h Anton Khirnov
2022-08-24 11:55 ` Andreas Rheinhardt
2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 03/18] lavf/dv: always provide avpriv_dv_* symbols Anton Khirnov
2022-08-24 16:25 ` Andreas Rheinhardt
2022-08-25 9:47 ` Anton Khirnov
2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 04/18] lavc/dvdec: drop the only use of DVVideoContext.avctx Anton Khirnov
2022-08-24 12:24 ` Andreas Rheinhardt
2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 05/18] lavc/dv: remove ff_dvvideo_init() Anton Khirnov
2022-08-24 12:27 ` Andreas Rheinhardt
2022-08-25 10:10 ` [FFmpeg-devel] [PATCH] " Anton Khirnov
2022-08-25 9:48 ` [FFmpeg-devel] [PATCH 05/18] " Anton Khirnov
2022-08-25 9:55 ` Anton Khirnov [this message]
2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 06/18] lavc/dv: do not pass DVVideoContext to ff_dv_init_dynamic_tables() Anton Khirnov
2022-08-24 12:28 ` Andreas Rheinhardt
2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 07/18] lavc/dv: do not pass DVVideoContext to dv_calculate_mb_xy() Anton Khirnov
2022-08-24 12:57 ` Andreas Rheinhardt
2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 08/18] lavc/dvdec: stop using DVVideoContext Anton Khirnov
2022-08-24 12:33 ` Andreas Rheinhardt
2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 09/18] lavc/dvenc: " Anton Khirnov
2022-08-24 12:36 ` Andreas Rheinhardt
2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 10/18] lavc/dv.h: move encoder/decoder-specific code to a new header Anton Khirnov
2022-08-24 12:52 ` Andreas Rheinhardt
2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 11/18] lavc/dv: rename constants to follow our naming conventions Anton Khirnov
2022-08-24 12:38 ` Andreas Rheinhardt
2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 12/18] lavf/dv: make returning the video packet optional Anton Khirnov
2022-08-24 16:03 ` Andreas Rheinhardt
2022-08-31 2:39 ` Anton Khirnov
2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 13/18] lavf/dv: return a meaningful error code from avpriv_dv_produce_packet() Anton Khirnov
2022-08-24 13:07 ` Andreas Rheinhardt
2022-08-31 2:48 ` [FFmpeg-devel] [PATCH] " Anton Khirnov
2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 14/18] lavf/dv: forward errors from avformat_new_stream() Anton Khirnov
2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 15/18] lavf/dv: set non-changing AVStream fields only once Anton Khirnov
2022-08-24 13:13 ` Andreas Rheinhardt
2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 16/18] lavf/dv: set audio bitrate only at stream creation Anton Khirnov
2022-08-24 13:13 ` Andreas Rheinhardt
2022-08-24 14:33 ` Andreas Rheinhardt
2022-08-25 10:23 ` Anton Khirnov
2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 17/18] lavf/dv: do not update AVCodecParameters.sample_rate while demuxing Anton Khirnov
2022-08-24 14:20 ` Andreas Rheinhardt
2022-08-31 3:11 ` Anton Khirnov
2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 18/18] lavf/dv: do not continuously set stream timebase Anton Khirnov
2022-08-24 14:42 ` Andreas Rheinhardt
2022-08-25 19:04 ` Marton Balint
2022-08-24 8:50 ` [FFmpeg-devel] [PATCH 01/18] tests/fate/mov: add a test for dv audio demuxed through dv demuxer Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166142134300.3205.2243600771551073974@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git