From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0363143E5D for ; Tue, 16 Aug 2022 11:22:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 57F9368B8B1; Tue, 16 Aug 2022 14:22:44 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2C49D68B7AD for ; Tue, 16 Aug 2022 14:22:38 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id D311C240179; Tue, 16 Aug 2022 13:22:37 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id goHUA-ly6H7C; Tue, 16 Aug 2022 13:22:37 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 3B36E2400F5; Tue, 16 Aug 2022 13:22:37 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 2EAD31601B2; Tue, 16 Aug 2022 13:22:37 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20220812125545.1229410-1-fei.w.wang@intel.com> References: <20220812125545.1229410-1-fei.w.wang@intel.com> Mail-Followup-To: FFmpeg development discussions and patches , Fei Wang , Linjie Fu Date: Tue, 16 Aug 2022 13:22:37 +0200 Message-ID: <166064895716.3205.18227206247708899551@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v1 1/3] lavc/decode: Add get_hw_config function X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Fei Wang , Linjie Fu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: The commit message is misleading - you are not adding code, you are moving code. Quoting Fei Wang (2022-08-12 14:55:43) > From: Linjie Fu > > Wrap the procedure of getting the hardware config from a pixel format > into a function. > > Signed-off-by: Linjie Fu > Signed-off-by: Fei Wang > --- > libavcodec/decode.c | 33 +++++++++++++++++++++------------ > 1 file changed, 21 insertions(+), 12 deletions(-) > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > index 75373989c6..d66d5a4160 100644 > --- a/libavcodec/decode.c > +++ b/libavcodec/decode.c > @@ -1156,6 +1156,26 @@ static void hwaccel_uninit(AVCodecContext *avctx) > av_buffer_unref(&avctx->hw_frames_ctx); > } > > +static const AVCodecHWConfigInternal *get_hw_config(AVCodecContext *avctx, enum AVPixelFormat fmt) > +{ > + const AVCodecHWConfigInternal *hw_config; > + int i; Should be declared in the loop > + if (ffcodec(avctx->codec)->hw_configs) { > + for (i = 0;; i++) { > + hw_config = ffcodec(avctx->codec)->hw_configs[i]; > + if (!hw_config) > + break; return NULL; > + if (hw_config->public.pix_fmt == fmt) > + break; return hw_config; > + } > + } else { > + hw_config = NULL; > + } You can save one level of indentation by starting with if (!ffcodec(avctx->codec)->hw_configs) return NULL; -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".