[FFmpeg-devel] [PATCH] tools: Make sure to create the tools directory before building decode_simple.o

[FFmpeg-devel] [PATCH] tools: Make sure to create the tools directory before building decode_simple.o

[Martin Storsjö]

This directory dependency is normally added implicitly by rules
in ffbuild/common.mak; for tools it's created by a rule for TOOLOBJS.
TOOLOBJS is populated implicitly from TOOLS, and decode_simple.o
doesn't end up there because it's an odd occurrance of a lone
object file in the tools subdirectory, not belonging to any other
tool.

---
This fixes stray fate errors where make tried to build this object
file when no other rule had ended up creating the tools directory
already, like this one:
http://fate.ffmpeg.org/log.cgi?time=20220808051007&slot=i686-mingw32-clang-trunk&log=test
---
 tools/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/Makefile b/tools/Makefile
index f4d1327b9f..4afa23342d 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -20,6 +20,8 @@ tools/target_io_dem_fuzzer.o: tools/target_dem_fuzzer.c
 tools/venc_data_dump$(EXESUF): tools/decode_simple.o
 tools/scale_slice_test$(EXESUF): tools/decode_simple.o
 
+tools/decode_simple.o: | tools
+
 OUTDIRS += tools
 
 clean::
-- 
2.32.0 (Apple Git-132)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] tools: Make sure to create the tools directory before building decode_simple.o

[Anton Khirnov]

Quoting Martin Storsjö (2022-08-08 10:59:51)
> This directory dependency is normally added implicitly by rules
> in ffbuild/common.mak; for tools it's created by a rule for TOOLOBJS.
> TOOLOBJS is populated implicitly from TOOLS, and decode_simple.o
> doesn't end up there because it's an odd occurrance of a lone
> object file in the tools subdirectory, not belonging to any other
> tool.
> 
> ---
> This fixes stray fate errors where make tried to build this object
> file when no other rule had ended up creating the tools directory
> already, like this one:
> http://fate.ffmpeg.org/log.cgi?time=20220808051007&slot=i686-mingw32-clang-trunk&log=test
> ---
>  tools/Makefile | 2 ++
>  1 file changed, 2 insertions(+)

Should be ok

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".