From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 922D043A76 for ; Sat, 6 Aug 2022 13:16:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2580C68B737; Sat, 6 Aug 2022 16:16:06 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DE25068B6AC for ; Sat, 6 Aug 2022 16:15:59 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 539D7240179 for ; Sat, 6 Aug 2022 15:15:59 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id pFvvNYKXWUwL for ; Sat, 6 Aug 2022 15:15:58 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 4313E2400F5 for ; Sat, 6 Aug 2022 15:15:58 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 7A0F51601B2; Sat, 6 Aug 2022 15:15:58 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: =?utf-8?q?=3CDB6PR0101MB22140B96C7CEE4C49267D8F38F619=40DB6PR01?= =?utf-8?q?01MB2214=2Eeurprd01=2Eprod=2Eexchangelabs=2Ecom=3E?= References: <20220805210039.4158-1-rcombs@rcombs.me> =?utf-8?q?=3CDB6PR0101M?= =?utf-8?q?B22140B96C7CEE4C49267D8F38F619=40DB6PR0101MB2214=2Eeurprd01=2Epro?= =?utf-8?q?d=2Eexchangelabs=2Ecom=3E?= Mail-Followup-To: FFmpeg development discussions and patches Date: Sat, 06 Aug 2022 15:15:58 +0200 Message-ID: <165979175846.3205.16694870576157746555@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lswr: take const AVChannelLayout* in swr_alloc_set_opts2() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2022-08-06 13:50:37) > rcombs: > > This is fully backwards-compatible in both ABI and API, > > so it's only a minor bump. > > It is not fully backwards-compatible API-wise: If you use a function > pointer for swr_alloc_set_opts2 by hardcoding its type, you will get > warnings now (or even errors depending upon your -Werror; it is an error > by default for C++). Given that I do not know about other language > bindings I have so far refrained from applying > https://patchwork.ffmpeg.org/project/ffmpeg/patch/AS1PR01MB95649A21F5F9A45D40E6AC1D8F1F9@AS1PR01MB9564.eurprd01.prod.exchangelabs.com/ > This does not mean that I block your patch; to the contrary: If it > breaks nothing, I will apply the above patch after a month or so. Maybe now could be a good time for a major bump, since we just had a release. It's also been two releases since the last one. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".